[Regression, Production] user contributions icon missing on AMC mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Feb 6 2020, 1:00 AM

Description

userContributions menu icon vanished in the AMC menu overflow, during the rename in rSMIN7b4b65a30f05: Reduce 'userContributions' icon code (deployed Mon 3rd). It's in production. We might have caught this sooner but mediawiki.org does not have AMC enabled.

Screen Shot 2020-02-06 at 6.17.16 AM.png (362×445 px, 23 KB)

It's using the class mw-ui-icon-minerva-contributions rather than mw-ui-icon-minerva-userContributions. Might as well upgrade the icon while fixing this to remove it from the repository.

Acceptance criteria

Restore the icon

QA steps

With AMC enabled and logged in click the person silhouette icon and verify all the menu items have logos

This is true on https://m.mediawiki.org/
This is true on https://en.m.wikipedia.org

QA Results

AC	Status	Details
1	✅	T244436#5893741
2	✅	T244436#5893741

Details

Subject	Repo	Branch	Lines +/-
Use OOUI icon for user contributions menu item	mediawiki/skins/MinervaNeue	master	+12 -11
Revert "Reduce 'userContributions' icon code"	mediawiki/skins/MinervaNeue	wmf/1.35.0-wmf.18	+6 -9
Revert "Reduce 'userContributions' icon code"	mediawiki/skins/MinervaNeue	master	+6 -9

Customize query in gerrit

Related Objects

Mentioned Here: T244444: Replace all possible, non-product specific icons in MobileFrontend/MinervaNeue with WikimediaUI/OOUI ones
rSMIN7b4b65a30f05: Reduce 'userContributions' icon code
T235939: Add "userContributions" icon in OOUI

Event Timeline

Volker_E created this task.Feb 6 2020, 1:00 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2020, 1:00 AM

I am seeing this icon already in minerva mobile (in both modes). Where do we want add it else? Related issue: I notice that, the contribs menu icon vanished in the AMC menu overflow, I am not sure when is started to happen. Is this something known? or is it related to this task?

Jdlrobson renamed this task from Use 'userContributions' icon from OOUI to [Regression, Production] user contributions icon missing on AMC mode.Feb 6 2020, 8:45 AM

Jdlrobson added projects: Regression, Web-Team-Backlog (Kanbanana-2019-20-Q3).

Jdlrobson updated the task description. (Show Details)

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptFeb 6 2020, 8:45 AM

Jdlrobson triaged this task as High priority.Feb 6 2020, 8:45 AM

phuedx updated the task description. (Show Details)Feb 6 2020, 9:43 AM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Feb 6 2020, 12:45 PM

Ammarpad claimed this task.Feb 6 2020, 3:58 PM

Change 570690 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[mediawiki/skins/MinervaNeue@master] Revert "Reduce 'userContributions' icon code"

https://gerrit.wikimedia.org/r/570690

gerritbot added a project: Patch-For-Review.Feb 6 2020, 6:31 PM

☝️ The above could be deployed during the morning or evening SWAT deployment windows.

@Jdlrobson We just have 'userContributions' in OOUI, several other of the same icons are missing still. From looking at the skin.json I'm not fully clear how the icons are currently put into the modules. 'wikimedia.ui' vs 'skins.minerva.icons.wikimedia' for example. We would have to further separate if we want to use OOUI's 'userContributions'.

Change 570769 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Update wrong icon reference in AMC overflow menu

https://gerrit.wikimedia.org/r/570769

Change 570690 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Revert "Reduce 'userContributions' icon code"

https://gerrit.wikimedia.org/r/570690

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 7 2020, 3:00 AM

Change 570779 had a related patch set uploaded (by Jdlrobson; owner: Phuedx):
[mediawiki/skins/MinervaNeue@wmf/1.35.0-wmf.18] Revert "Reduce 'userContributions' icon code"

https://gerrit.wikimedia.org/r/570779

https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/570779/ needs to be SWATTed otherwise it will be broken until next Thursday.
There are no SWAT windows on Friday. Possibly @phuedx may be able to make an exception.

The other issues relating to OOUI icons in this ticket are not time sensitive.

Change 570882 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MinervaNeue@master] Use OOUI icon for user contributions menu item

https://gerrit.wikimedia.org/r/570882

Change 570779 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.35.0-wmf.18] Revert "Reduce 'userContributions' icon code"

https://gerrit.wikimedia.org/r/570779

Jdlrobson reassigned this task from Ammarpad to Edtadros.Feb 11 2020, 12:25 AM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.18; 2020-02-04); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 11 2020, 1:00 AM

@phuedx should this be tested on mediawiki.org? If there is a beta environment let me know.

@phuedx Per our conversation I'm putting this in needs more work. As discussed please add any additional comments regarding the state of the task and any testing instructions.

I recommended that @Edtadros move this to Needs More Work as:

https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/570882/ is C-1 with a recommendation to defer to…
https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/570769/, which is C-1 V-1

phuedx reassigned this task from phuedx to Jdlrobson.Feb 13 2020, 1:24 PM

Jdlrobson updated the task description. (Show Details)Feb 14 2020, 7:14 PM

In T244436#5880170, @phuedx wrote:

I recommended that @Edtadros move this to Needs More Work as:

https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/570882/ is C-1 with a recommendation to defer to…

https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/570769/, which is C-1 V-1

Those patches are associated with T244444 which appears to have been broken out and is in upcoming. Adding this to QA.

Change 570882 abandoned by Ammarpad:
Use OOUI icon for user contributions menu item

Reason:
Done in another patch I0f929f2

https://gerrit.wikimedia.org/r/570882

ovasileva reassigned this task from Jdlrobson to Edtadros.Feb 17 2020, 6:05 PM

Test Result

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps

With AMC enabled and logged in click the person silhouette icon and verify all the menu items have logos

✅ AC1: This is true on https://m.mediawiki.org/

m.mediawiki.org_wiki_MediaWiki(iPhone X).png (2×1 px, 407 KB)

✅ AC2: This is true on https://en.m.wikipedia.org

en.m.wikipedia.org_wiki_Main_Page(iPhone X).png (2×1 px, 865 KB)

Edtadros updated the task description. (Show Details)Feb 18 2020, 5:24 PM

ovasileva closed this task as Resolved.Feb 19 2020, 9:35 AM

	F31621390: m.mediawiki.org_wiki_MediaWiki(iPhone X).png
	Feb 18 2020, 5:24 PM

	F31621392: en.m.wikipedia.org_wiki_Main_Page(iPhone X).png
	Feb 18 2020, 5:24 PM

	F31551740: Screen Shot 2020-02-06 at 6.17.16 AM.png
	Feb 6 2020, 5:23 AM

[Regression, Production] user contributions icon missing on AMC modeClosed, ResolvedPublicActions