Page MenuHomePhabricator

Allow the creation of skins with services injected
Closed, ResolvedPublic

Description

The SkinFactory supports the creation of skins through a factory function but does not offer the option to allow the creation of skins with services injected. Given that the SkinFactory already uses the same pattern as SpecialPageFactory, which was previously altered to allow services to be injected when creating special pages (T222388), the same adjustment can be made to allow the registration of Skins with ObjectFactory spec. This delegates the actual object creation of Skin objects to ObjectFactory. ObjectFactory supports providing a callable as spec, making the change backwards compatible.

Event Timeline

Change 570598 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/core@master] Support the creation of Skins with services injected

https://gerrit.wikimedia.org/r/570598

Change 570598 merged by jenkins-bot:
[mediawiki/core@master] Support the creation of Skins with services injected

https://gerrit.wikimedia.org/r/570598

Mainframe98 closed this task as Resolved.Mar 17 2020, 3:59 PM