Use IndexPager's multi-column pagination for preliminary check
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Feb 6 2020, 6:33 PM

Description

After T244492 we can remove the multiple column pagination from PreliminaryCheckService, since it will be handled by IndexPager.

We can define the multiple index fields in PreliminaryCheckPager::getIndexField, after which we can stop overriding IndexPager::doQuery, and instead override IndexPager::getQueryInfo and IndexPager::preprocessResults.

In doing this, we will also remove the virtual column lu_name_wiki, which currently causes errors when using Special:Investigate without CentralAuth enabled.

Details

	Subject	Repo	Branch	Lines +/-
	Update preliminary check classes to use multi-column pagination	mediawiki/extensions/CheckUser	master	+171 -248

Customize query in gerrit

Related Objects

Mentioned In: T238827: Reorganise preliminary check service for paginated results
T244492: Support pagination on multiple columns in IndexPager
T239680: CU 2.0: Persist the form state
Mentioned Here: T244157: Special:BlockList paginates on a non-unique column
T244492: Support pagination on multiple columns in IndexPager

Event Timeline

Tchanders created this task.Feb 6 2020, 6:33 PM

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptFeb 6 2020, 6:33 PM

Tchanders updated the task description. (Show Details)Feb 7 2020, 1:22 AM

Tchanders mentioned this in T239680: CU 2.0: Persist the form state.Feb 7 2020, 1:25 AM

Tchanders claimed this task.Feb 7 2020, 2:05 AM

Tchanders moved this task from Triage/To be Estimated to The Letter Song on the Anti-Harassment board.

Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 572040 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] Update preliminary check classes to use multi-column pagination

https://gerrit.wikimedia.org/r/572040

gerritbot added a project: Patch-For-Review.Feb 13 2020, 5:22 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 14 2020, 1:18 AM

Change 572040 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Update preliminary check classes to use multi-column pagination

https://gerrit.wikimedia.org/r/572040

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 14 2020, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2020, 9:10 PM

MGChecker unsubscribed.Feb 14 2020, 11:17 PM

dbarratt moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Feb 17 2020, 11:08 PM

Tchanders mentioned this in T244492: Support pagination on multiple columns in IndexPager.Feb 18 2020, 12:36 PM

dom_walden mentioned this in T238827: Reorganise preliminary check service for paginated results.Feb 19 2020, 2:19 PM