Page MenuHomePhabricator

Deprecate and remove ArticleEditUpdatesDeleteFromRecentchanges hook
Closed, ResolvedPublic

Description

The DerivedPageDataUpdater class has a legacy hook called ArticleEditUpdatesDeleteFromRecentchanges.

This legacy hook means the page updator also pulls in responsibility for (semi-randomly) queuing RecentChangesUpdateJob jobs.

To clean this up, this task tracks migration of the hook in any core/wmf-maintained code bases, deprecation, and (after 1 release cycle) removal.

Event Timeline

Change 523293 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/core@master] Deprecate the ArticleEditUpdatesDeleteFromRecentchanges hook

https://gerrit.wikimedia.org/r/523293

Change 522381 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@master] Remove ArticleEditUpdatesDeleteFromRecentchanges hook, deprecated in 1.34

https://gerrit.wikimedia.org/r/522381

I've tagged old/unfinished patches for these but I don't know if they are salvagable or not. This started as something @aaron worked on at some point prior to DerivedPageDataUpdater being stewarded by CPT (via @daniel). It was unfinished in Gerrit and the work involved with it and/or the CR is hereby tracked on Phabricator.

Marking as ready for deprecation given core and deployed use has been migrated.

Change 523293 merged by jenkins-bot:
[mediawiki/core@master] Deprecate the ArticleEditUpdatesDeleteFromRecentchanges hook

https://gerrit.wikimedia.org/r/523293

Change 522381 merged by jenkins-bot:

[mediawiki/core@master] Remove ArticleEditUpdatesDeleteFromRecentchanges hook, deprecated in 1.35

https://gerrit.wikimedia.org/r/522381

Change 681735 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@REL1_36] Remove ArticleEditUpdatesDeleteFromRecentchanges hook, deprecated in 1.35

https://gerrit.wikimedia.org/r/681735

Change 681735 merged by jenkins-bot:

[mediawiki/core@REL1_36] Remove ArticleEditUpdatesDeleteFromRecentchanges hook, deprecated in 1.35

https://gerrit.wikimedia.org/r/681735