Page MenuHomePhabricator

Please clear two stuck notifications for MABot
Closed, ResolvedPublic

Description

This is the same as T218104 which is happening again.

With the Wikimedia account MABot logged-in, I keep seeing that I have two unread notifications from es.wiktionary and eu.wiktionary. When clicking on the icon, empty boxes are shown, and there's no way to mark them as read as they keep appearing.

Both notifications have now more than 7 months.

At this stage, I guess we'll need to delete those from the database directly or do something else?

Thanks.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

In the database, I do see 1 unread notification each for MABot on eswiktionary and euwikibooks. They're both "thank you for your 100th edit" notifications. The one on eswiktionary is from July 2019, and the one on euwikibooks is from April 2019. However, MABot has disabled thank-you-edit notifications using global preferences. I think this is probably the source of the bug: saving one's global preferences only causes notification counts to be recomputed on the wiki where you did that, not globally (and generally, hooks listening for preference changes won't be fired when the preference change happens through global preferences).

I've manually recached the notification counts for MABot on these two wikis, that should fix the issue

catrope@mwmaint1002:~$ mwscript eval.php euwikibooks
> $user = User::newFromName('MABot');

> $nu = MWEchoNotifUser::newFromUser($user);

> $nu->resetNotificationCount();

(and then the same thing for eswiktionary)