Special:RandomInCategory disregards query string
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Cobaltcigs
	Feb 8 2020, 2:16 PM

Description

First url preserves the wgAction but the second does not:

Because apparently they were written differently. Making the following change to ./specials/SpecialRandomInCategory.php seems to succeed:

@@ -142,11 +142,13 @@ class SpecialRandomInCategory extends FormSpecialPage {
 				$this->category->getText() );
 
 			return Status::newFatal( $msg );
 		}
 
-		$this->getOutput()->redirect( $title->getFullURL() );
+		$query = $this->getRequest()->getValues();
+		unset( $query['title'] );
+		$this->getOutput()->redirect( $title->getFullURL($query) );
 	}
 
 	/**
 	 * Choose a random title.
 	 * @return Title|null Title object (or null if nothing to choose from)

Details

	Subject	Repo	Branch	Lines +/-
	SpecialRandomInCategory.php: preserve query string during redirection	mediawiki/core	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T309907: Special RandomInCategory should not ouput the edittoken to the URL

Event Timeline

Cobaltcigs created this task.Feb 8 2020, 2:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2020, 2:16 PM

Hi @Cobaltcigs, thanks for taking a look at the code!

You are very welcome to use developer access to submit the proposed code changes as a Git branch directly into Gerrit which makes it easier to review and provide feedback. If you don't want to set up Git/Gerrit, you can also use the Gerrit Patch Uploader. Thanks again!

Change 570999 had a related patch set uploaded (by Cobaltcigs; owner: Cobaltcigs):
[mediawiki/core@master] preserve query string for Special:RandomInCategory (T244641)

https://gerrit.wikimedia.org/r/570999

gerritbot added a project: Patch-For-Review.Feb 8 2020, 3:24 PM

Ammarpad updated the task description. (Show Details)Feb 8 2020, 5:05 PM

TheDJ subscribed.Feb 8 2020, 10:37 PM

Change 570999 had a related patch set uploaded (by Cobaltcigs; owner: Cobaltcigs):
[mediawiki/core@master] SpecialRandomInCategory.php: preserve query string during redirection

https://gerrit.wikimedia.org/r/570999

Change 571064 had a related patch set uploaded (by Cobaltcigs; owner: Cobaltcigs):
[mediawiki/core@master] CategoryViewer.php: omit <h3> for whitespace sortkey header, improve vertical alignment of columns

https://gerrit.wikimedia.org/r/571064

Change 570999 merged by jenkins-bot:
[mediawiki/core@master] SpecialRandomInCategory.php: preserve query string during redirection

https://gerrit.wikimedia.org/r/570999

Ammarpad closed this task as Resolved.Feb 9 2020, 4:17 PM

Ammarpad assigned this task to Cobaltcigs.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 9 2020, 5:00 PM

Xaosflux mentioned this in T309907: Special RandomInCategory should not ouput the edittoken to the URL.Jun 4 2022, 4:05 PM