Page MenuHomePhabricator

Missing text in button in ClaimMentee e-mail notification
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Change someones mentor
  2. Look at his mail notificaton

Actual Results:

There is no text in blue button, clicking on it opens mentors user page.

image.png (801×263 px, 12 KB)

Error

MediaWiki version: 1.35.0-wmf.16

message
PHP Notice: Undefined index: label

Impact

Exception is thrown on sending email notification that mentor changed.

Notes

This occurs because EchoMentorChangePresentationModel.php in GrowthExperiments does not define a label in getPrimaryLink(). The presentation model docs require it:

	/**
	 * Array of primary link details, with possibly-relative URL & label.
	 *
	 * @return array|false Array of link data, or false for no link:
	 *                    ['url' => (string) url, 'label' => (string) link text (non-escaped)]
	 */
	abstract public function getPrimaryLink();

Related Objects

Event Timeline

Doesn't look as bad, thought it's only an indentation thing.

Cause: No label in getPrimaryLink().

Question is what copy we want to have there. "View mentor's userpage"?

View mentor's userpage sounds good. In my opinion should be buttons switched, for me is more importatnt contacting mentor, than viewing his userpage.

Change 571539 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Add Learn more about your new mentor to the claimmentee notification

https://gerrit.wikimedia.org/r/571539

Change 571539 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add Learn more about your new mentor to the claimmentee notification

https://gerrit.wikimedia.org/r/571539

Etonkovidova subscribed.

Checked in betalabs:

Screen Shot 2020-02-13 at 4.20.28 PM.png (910×391 px, 39 KB)