Visual Editor moves ProofreadPage haeader / footer into page text field, duplicating them.
Recent example of such edit:
https://pl.wikisource.org/w/index.php?title=Strona%3AM._Arcta_S%C5%82ownik_Staropolski.djvu%2F0354&type=revision&diff=2440000&oldid=1973406
Note: this should no longer be a problem for plwikisource, as similar edits are now blocked by Abusefillter. But this may be problem for VE users who may be not able to edit until this is fixed.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| VE: Fix handling header/footer when generating HTML to save | mediawiki/extensions/ProofreadPage | master | +6 -4 |
So far as I know this happens consistently for every user of every language Wikisource. Hence why the Wikisourcen cannot enable VisualEditor by default in their content namespaces.
But that being said, I do not believe this is a new issue, and there should be duplicates rattling around Phabricator somewhere (I just don't have time to hunt them down just now, sorry).
I'm pinging @Samwilson and @satdeep_gill, who are experienced Wikisource editors. We would love your insights on the issue detailed in this ticket. Is this a challenge a lot of people are encountering? Thank you!
@JTannerWMF I just merged in a couple of dups of this. It gets ran into regularly across multiple languages, but it mostly just gets filed under "Visual Editor doesn't work on Wikisource".
Change 758103 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/ProofreadPage@master] VE: Fix handling header/footer when generating HTML to save
Change 758103 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] VE: Fix handling header/footer when generating HTML to save
(@Xover pointed out this bug to me while discussing something else, and I realized it was caused by some maintenance work we did in VisualEditor in 2019 to share some code used for saving edits with DiscussionTools, and trivial to fix. Sorry it took us so long to notice…)