Page MenuHomePhabricator

Dev: SpecialEditWatchlist::__construct() requires WatchedItemStoreInterface in SpecialMobileEditWatchlist::__construct()
Closed, ResolvedPublic

Description

SpecialMobileEditWatchlist::__construct() calls SpecialEditWatchlist::__construct() which requires WatchedItemStoreInterface as argument.

14:00:28 <checkstyle version="6.5">
14:00:28   <file name="includes/specials/SpecialMobileEditWatchlist.php">
14:00:28     <error line="15" severity="error" message="Call with 0 arg(s) to \SpecialEditWatchlist::__construct(\WatchedItemStoreInterface $watchedItemStore) which requires 1 arg(s) defined at ../../includes/specials/SpecialEditWatchlist.php:66" source="PhanParamTooFew"/>
14:00:28   </file>
14:00:28 </checkstyle>

Causes this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/571054 to fail with error severity level. See more information here: https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/34662/console

Event Timeline

Change 571059 had a related patch set uploaded (by D3r1ck01; owner: Derick A):
[mediawiki/extensions/MobileFrontend@master] specials: Pass WatchItemStoreInterface to SpecialEditWatchlist::__construct()

https://gerrit.wikimedia.org/r/571059

Jdlrobson renamed this task from SpecialEditWatchlist::__construct() requires WatchedItemStoreInterface in SpecialMobileEditWatchlist::__construct() to Dev: SpecialEditWatchlist::__construct() requires WatchedItemStoreInterface in SpecialMobileEditWatchlist::__construct().Feb 9 2020, 10:57 PM

Change 571059 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] specials: Pass WatchItemStoreInterface to SpecialEditWatchlist::__construct()

https://gerrit.wikimedia.org/r/571059

xSavitar claimed this task.

Thanks for reviewing @Jdlrobson!