Page MenuHomePhabricator

wmerrors needs tests
Closed, ResolvedPublic

Description

The wmerrors PHP extension currently has no tests - would be nice to have some.

Event Timeline

Change 759382 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/php/wmerrors@master] Add basic test verifying fatal error log format

https://gerrit.wikimedia.org/r/759382

Change 759382 merged by jenkins-bot:

[mediawiki/php/wmerrors@master] Add basic test verifying fatal error log format

https://gerrit.wikimedia.org/r/759382

Krinkle added subscribers: tstarling, Krinkle.

@tstarling @Legoktm If I recall correctly, you two mentioned somewhere that php-wmerrors had an issue with PHP 8.1. Does the above test case also cover that bug? Or should we keep this open for that additional test (assuming it's feasible test?).

Krinkle triaged this task as Medium priority.Dec 12 2022, 7:54 PM

Yep, Tim fixed the bug with https://gerrit.wikimedia.org/r/c/mediawiki/php/wmerrors/+/866833/ and that's what enabled CI to pass on my patch. The single test is good enough for me, there's probably more that could be covered, but I'll defer to Tim on that.