Page MenuHomePhabricator

Add interface for changing mentor
Closed, ResolvedPublic

Description

We have encouraged the need to change mentor for a user. We should let admins to manipulate with the mentor setting, through API and a special page. Special:ClaimMentee is not enough, since that can't change someone else mentor to someone else. Special:ClaimMentee is opened to everybody, the new special page would be sysop-only.

API patch is coming soon...

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 571293 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Add API for changing mentor

https://gerrit.wikimedia.org/r/571293

Change 571293 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add API for changing mentor

https://gerrit.wikimedia.org/r/571293

@Urbanecm
Checked on enwiki betalabs.

A sysop can successfully assign a mentor who is

  • not on Wikipedia:Mentors page
  • is the same user as a mentee
/w/api.php?action=growthsetmentor&format=json&mentee=ET103&mentor=ET103&reason=test%202%20for%20changing%20mentors%20by%20sysop%20-%20not%20valid%20entries
{
    "growthsetmentor": {
        "status": "ok",
        "mentee": "ET103",
        "newMentor": "ET103"
    }
}

Special:ClaimMentee does not allow a non-mentor (not on the list of mentors) to view the page. Should growthsetmentor check for Wikipedia:Mentors and if it's a mentee is the same user as a mentor?

Otherwise, all works as expected. A mentee gets the notification - "[a username] is your new mentor"; the mentor does not get any notifications.

@Urbanecm
Checked on enwiki betalabs.

A sysop can successfully assign a mentor who is

  • not on Wikipedia:Mentors page
  • is the same user as a mentee
/w/api.php?action=growthsetmentor&format=json&mentee=ET103&mentor=ET103&reason=test%202%20for%20changing%20mentors%20by%20sysop%20-%20not%20valid%20entries
{
    "growthsetmentor": {
        "status": "ok",
        "mentee": "ET103",
        "newMentor": "ET103"
    }
}

Special:ClaimMentee does not allow a non-mentor (not on the list of mentors) to view the page. Should growthsetmentor check for Wikipedia:Mentors and if it's a mentee is the same user as a mentor?

Per the user feedback for the special page, it should maybe be the other way around (relax ClaimMentee), cf T244564.

Otherwise, all works as expected. A mentee gets the notification - "[a username] is your new mentor"; the mentor does not get any notifications.

Great!

MMiller_WMF subscribed.

I think this has been safely deployed.