Page MenuHomePhabricator

web installer / upgrade doesn't seem to recognize extension.json configuration or overrides to that configuration
Open, MediumPublic

Description

While working on T165317 it became apparent that Echo's configuration was not being loaded in the hook which loads schema updates. In searching phab I also found T88946 which seems to describe a similar problem (extension defines a configuration variable as an array, and the bug reporter notes errors that seem to imply that configuration variable is NULL).

The web installer / upgrade should be able to read extension defined configuration as well as overrides to that configuration from LocalSettings.php.

Event Timeline

kostajh created this task.Feb 11 2020, 2:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2020, 2:11 PM
WDoranWMF moved this task from Triage Meeting Inbox to Icebox on the Platform Engineering board.
WDoranWMF added a subscriber: WDoranWMF.

@kostajh Could you give us a sense of the priority level here? Is this blocking for anything?

We're not positive if we own this or if we should be the ones to pick it up, does Release-Engineering-Team have any opinions?

I'm going to move it to the icebox for now but can revisit based on priority.

Hi @WDoranWMF not blocking anything for Growth-Team, we merged a patch that works around this problem for Notifications (T165317). But basically this task means that upgrading extensions is error prone for those who can manage a wiki only through the web UI and don't have command-line access. Maybe someone from MediaWiki-Stakeholders-Group could weigh in on the priority?

greg added a subscriber: greg.Feb 12 2020, 8:39 PM

We're not positive if we own this or if we should be the ones to pick it up, does Release-Engineering-Team have any opinions?

Contrary to our name, we actually aren't really responsible for ensuring all parts of the 3rd party MW installer works, sadly. See https://www.mediawiki.org/wiki/Developers/Maintainers and search "installer". This is, again sadly, an unfunded part of MW maintenance.

Akuckartz triaged this task as Medium priority.Jun 15 2020, 6:55 PM

This is on purpose. The only thing loaded during the web installer are classes for autoloading and the schema update hook itself (and then any maintenance that needs to run). Configuration is explicitly not loaded. The expectation is that the schema is universal regardless of configuration.