Page MenuHomePhabricator
Create Task
Maniphest T244923

Hard deprecate Title::userCan
Closed, ResolvedPublic
Actions

Description

See parent task

Codesearch for userCan calls: https://codesearch.wmflabs.org/deployed/?q=-%3EuserCan%5C(&i=nope&files=php%24&repos=

These need to be checked for if they are called on a title method

Calls to Title::userCan:

All other callers from mediawiki deployed code refer to a different userCan (eg PermissionManager::userCan)

Details

SubjectRepoBranchLines +/-
Hard deprecate Title::userCan and ::quickUserCanmediawiki/coremaster+26 -1
Remove use of Title::userCanmediawiki/extensions/GettingStartedmaster+17 -9
Remove use of Title::userCanmediawiki/extensions/FlaggedRevsmaster+5 -1
Remove use of Title::userCanmediawiki/extensions/SubPageList3master+13 -2
Remove use of Title::userCanmediawiki/extensions/Translatemaster+12 -6
Remove use of Title::userCanmediawiki/extensions/MassMessagemaster+7 -3
Remove use of Title::userCanmediawiki/extensions/LiquidThreadsmaster+9 -5
Remove use of Title::userCanmediawiki/extensions/Jademaster+4 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Feb 11 2020, 8:39 PM
DannyS712 updated the task description. (Show Details)Feb 11 2020, 8:52 PM
DannyS712 edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Feb 11 2020, 9:04 PM
DannyS712 mentioned this in T244922: Hard deprecate Title user permission methods.Feb 12 2020, 7:15 AM
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Feb 12 2020, 8:28 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 added a comment.Feb 13 2020, 7:28 AM

https://codesearch.wmflabs.org/deployed/?q=-%3EuserCan%5C(&i=nope&files=php%24&repos=MediaWiki%20core,mediawiki/extensions/FlaggedRevs,mediawiki/extensions/GettingStarted,mediawiki/extensions/Jade,mediawiki/extensions/LiquidThreads,mediawiki/extensions/MassMessage,mediawiki/extensions/SubPageList3,mediawiki/extensions/Translate filters out most of the false positives

gerritbot added a comment.Feb 13 2020, 7:30 AM

Change 571873 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SubPageList3@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/571873

gerritbot added a project: Patch-For-Review.Feb 13 2020, 7:30 AM
DannyS712 moved this task from Next to In progress on the User-DannyS712 board.Feb 13 2020, 7:34 AM
gerritbot added a comment.Feb 13 2020, 7:34 AM

Change 571874 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/571874

gerritbot added a comment.Feb 13 2020, 7:36 AM

Change 571875 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GettingStarted@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/571875

DannyS712 added projects: MediaWiki-extensions-Other, MediaWiki-extensions-LiquidThreads, MediaWiki-extensions-GettingStarted.Feb 13 2020, 7:38 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 13 2020, 7:38 AM
gerritbot added a comment.Feb 13 2020, 4:52 PM

Change 572029 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/572029

gerritbot added a comment.Feb 13 2020, 4:57 PM

Change 572030 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/572030

DannyS712 added projects: Jade, MediaWiki-extensions-FlaggedRevs.Feb 13 2020, 5:00 PM
gerritbot added a comment.Feb 13 2020, 6:01 PM

Change 572029 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/572029

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 13 2020, 7:00 PM
DannyS712 updated the task description. (Show Details)Feb 13 2020, 7:48 PM
gerritbot added a comment.Feb 13 2020, 7:49 PM

Change 572073 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/572073

gerritbot added a comment.Feb 13 2020, 7:54 PM

Change 572075 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/572075

DannyS712 added projects: MassMessage, MediaWiki-extensions-Translate.Feb 13 2020, 7:56 PM
DannyS712 updated the task description. (Show Details)
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Feb 13 2020, 8:41 PM

Change 571874 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/571874

gerritbot added a comment.Feb 13 2020, 8:51 PM

Change 572073 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/572073

gerritbot added a comment.Feb 13 2020, 8:59 PM

Change 572075 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/572075

DannyS712 triaged this task as Medium priority.Feb 13 2020, 9:07 PM
DannyS712 moved this task from Awaiting review and deployment to In progress on the User-DannyS712 board.
DannyS712 updated the task description. (Show Details)
gerritbot added a comment.Feb 13 2020, 9:15 PM

Change 572094 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] EditPage: Remove use of Title::getUserPermissionsErrors (part 1)

https://gerrit.wikimedia.org/r/572094

DannyS712 added a comment.Feb 13 2020, 9:22 PM

Woops, wrong task to link

gerritbot added a comment.Feb 15 2020, 2:20 AM

Change 571873 merged by jenkins-bot:
[mediawiki/extensions/SubPageList3@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/571873

gerritbot added a comment.Feb 16 2020, 3:00 AM

Change 572030 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/572030

DannyS712 updated the task description. (Show Details)Feb 16 2020, 3:13 AM
gerritbot added a comment.Feb 20 2020, 11:07 AM

Change 571875 merged by jenkins-bot:
[mediawiki/extensions/GettingStarted@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/571875

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 20 2020, 12:00 PM
DannyS712 updated the task description. (Show Details)Feb 20 2020, 5:29 PM
DannyS712 edited projects, added MediaWiki-extensions-SubPageList3; removed MediaWiki-extensions-Other.Feb 21 2020, 3:30 PM
DannyS712 mentioned this in T243708: Mediawiki core needs uses of global $wgUser removed.Feb 22 2020, 1:18 AM
gerritbot added a comment.Feb 22 2020, 1:24 AM

Change 574138 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Title::userCan and ::quickUserCan

https://gerrit.wikimedia.org/r/574138

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Feb 22 2020, 1:32 AM
gerritbot added a comment.Feb 22 2020, 2:37 AM

Change 574138 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Title::userCan and ::quickUserCan

https://gerrit.wikimedia.org/r/574138

DannyS712 closed this task as Resolved.Feb 22 2020, 2:45 AM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Feb 23 2020, 10:22 AM
Nikerabbit added a subtask: T246082: Use of Title::userCan was deprecated in MediaWiki 1.33. [Called from PFHelperFormAction::displayTab.Feb 25 2020, 10:00 AM
DannyS712 removed a subtask: T246082: Use of Title::userCan was deprecated in MediaWiki 1.33. [Called from PFHelperFormAction::displayTab.Feb 25 2020, 6:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL