Page MenuHomePhabricator
Create Task
Maniphest T244929

Hard deprecate Title::getUserPermissionsErrors
Closed, ResolvedPublic
Actions

Assigned To
DannyS712
Authored By
DannyS712
Feb 11 2020, 9:03 PM
Tags
Referenced Files
None
Subscribers
Aklapper
DannyS712

Description

See parent task for reasoning

Codesearch: https://codesearch.wmflabs.org/deployed/?q=-%3EgetUserPermissionsErrors%5C(&i=nope&files=php%24&repos=

All usage in WMF deployed extensions have been removed as of 1.35-wmf.20 (2020-02-18)

  • Core uses (outside of tests)
  • Core actual deprecation

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Feb 11 2020, 9:03 PM
DannyS712 edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Feb 11 2020, 9:04 PM
gerritbot added a comment.Feb 11 2020, 9:24 PM

Change 571580 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Nuke@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571580

gerritbot added a project: Patch-For-Review.Feb 11 2020, 9:24 PM
DannyS712 added a project: MediaWiki-extensions-Nuke.Feb 11 2020, 9:26 PM
gerritbot added a comment.Feb 11 2020, 11:28 PM

Change 571591 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571591

DannyS712 added a project: PageTriage.Feb 11 2020, 11:30 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 11 2020, 11:30 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Feb 11 2020, 11:31 PM
gerritbot added a comment.Feb 11 2020, 11:31 PM

Change 571593 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaEvents@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571593

DannyS712 added a project: MediaWiki-extensions-WikimediaEvents.Feb 11 2020, 11:34 PM
gerritbot added a comment.Feb 11 2020, 11:34 PM

Change 571594 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Newsletter@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571594

DannyS712 added a project: MediaWiki-extensions-Newsletter.Feb 11 2020, 11:38 PM
gerritbot added a comment.Feb 11 2020, 11:55 PM

Change 571597 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ArticlePlaceholder@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571597

DannyS712 added a project: ArticlePlaceholder.Feb 11 2020, 11:57 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 11 2020, 11:57 PM
gerritbot added a comment.Feb 11 2020, 11:58 PM

Change 571599 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571599

DannyS712 added a project: MediaWiki-extensions-Translate.Feb 12 2020, 12:01 AM
gerritbot added a comment.Feb 12 2020, 12:04 AM

Change 571602 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571602

DannyS712 added a project: MediaWiki-extensions-LiquidThreads.Feb 12 2020, 12:07 AM
DannyS712 updated the task description. (Show Details)Feb 12 2020, 12:09 AM
DannyS712 mentioned this in T244922: Hard deprecate Title user permission methods.Feb 12 2020, 7:15 AM
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Feb 12 2020, 8:28 AM
CCicalese_WMF added a project: Platform Team Workboards (Clinic Duty Team).Feb 12 2020, 7:36 PM
CCicalese_WMF moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
gerritbot added a comment.Feb 12 2020, 8:32 PM

Change 571597 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571597

gerritbot added a comment.Feb 12 2020, 8:32 PM

Change 571593 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571593

gerritbot added a comment.Feb 12 2020, 8:38 PM

Change 571591 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571591

gerritbot added a comment.Feb 12 2020, 8:38 PM

Change 571580 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571580

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 12 2020, 9:00 PM
gerritbot added a comment.Feb 12 2020, 11:00 PM

Change 571599 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571599

gerritbot added a comment.Feb 12 2020, 11:00 PM

Change 571594 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571594

gerritbot added a comment.Feb 12 2020, 11:00 PM

Change 571602 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Remove use of Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/571602

Maintenance_bot removed a project: Patch-For-Review.Feb 12 2020, 11:10 PM
DannyS712 updated the task description. (Show Details)Feb 13 2020, 12:21 AM
gerritbot added a comment.Feb 13 2020, 9:22 PM

Change 572094 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] EditPage: Remove use of Title::getUserPermissionsErrors (part 1)

https://gerrit.wikimedia.org/r/572094

gerritbot added a project: Patch-For-Review.Feb 13 2020, 9:22 PM
gerritbot added a comment.Feb 14 2020, 5:37 AM

Change 572094 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Remove use of Title::getUserPermissionsErrors (part 1)

https://gerrit.wikimedia.org/r/572094

gerritbot added a comment.Feb 14 2020, 5:47 AM

Change 572146 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Special pages: Remove use of Title::getUserPermissionsErrors (part 2)

https://gerrit.wikimedia.org/r/572146

Art-Baltai moved this task from External Code Review Needed to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Feb 14 2020, 4:37 PM
DannyS712 triaged this task as Medium priority.Feb 15 2020, 12:41 AM
gerritbot added a comment.Feb 15 2020, 12:43 AM

Change 572370 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Article: Remove use of Title::getUserPermissionsErrors (part 3)

https://gerrit.wikimedia.org/r/572370

DannyS712 added a comment.Feb 15 2020, 12:58 AM

Doing the core patches separately because they sometimes include other changes, and to ease review / avoid merge conflicts

gerritbot added a comment.Feb 18 2020, 10:31 PM

Change 573001 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] MergeHistory: Remove use of Title::getUserPermissionsErrors (part 4)

https://gerrit.wikimedia.org/r/573001

gerritbot added a comment.Feb 18 2020, 11:04 PM

Change 573001 merged by jenkins-bot:
[mediawiki/core@master] MergeHistory: Remove use of Title::getUserPermissionsErrors (part 4)

https://gerrit.wikimedia.org/r/573001

gerritbot added a comment.Feb 18 2020, 11:40 PM

Change 567324 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] FileDeleteForm: Add a user to constructor, hard deprecate not providing

https://gerrit.wikimedia.org/r/567324

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 19 2020, 12:01 AM
gerritbot added a comment.Feb 19 2020, 12:01 AM

Change 572146 merged by jenkins-bot:
[mediawiki/core@master] Special pages: Remove use of Title::getUserPermissionsErrors (part 2)

https://gerrit.wikimedia.org/r/572146

gerritbot added a comment.Feb 19 2020, 1:31 AM

Change 567324 merged by jenkins-bot:
[mediawiki/core@master] FileDeleteForm: Add a user to constructor, hard deprecate not providing

https://gerrit.wikimedia.org/r/567324

gerritbot added a comment.Feb 20 2020, 9:45 AM

Change 573534 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace calls to Title::getUserPermissionsErrors (part 5)

https://gerrit.wikimedia.org/r/573534

gerritbot added a comment.Feb 21 2020, 5:05 AM

Change 572370 merged by jenkins-bot:
[mediawiki/core@master] Article: Remove use of Title::getUserPermissionsErrors (part 3)

https://gerrit.wikimedia.org/r/572370

gerritbot added a comment.Feb 26 2020, 3:28 AM

Change 573534 merged by jenkins-bot:
[mediawiki/core@master] Replace calls to Title::getUserPermissionsErrors (part 5)

https://gerrit.wikimedia.org/r/573534

Maintenance_bot removed a project: Patch-For-Review.Feb 26 2020, 4:10 AM
gerritbot added a comment.Feb 26 2020, 4:26 AM

Change 574918 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/574918

gerritbot added a project: Patch-For-Review.Feb 26 2020, 4:26 AM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Feb 26 2020, 4:39 AM
gerritbot added a comment.Feb 26 2020, 6:29 AM

Change 574918 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Title::getUserPermissionsErrors

https://gerrit.wikimedia.org/r/574918

DannyS712 closed this task as Resolved.Feb 26 2020, 6:30 AM
DannyS712 removed a project: Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.22; 2020-03-03); removed MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 26 2020, 4:02 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Mar 4 2020, 7:54 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL