Page MenuHomePhabricator
Create Task
Maniphest T244943

Ensure HistoryPager properties are consistent with IndexPager types
Closed, ResolvedPublic
Actions

Description

$mLastShown, $mFirstShown and $mPastTheEndIndex should be arrays, since T244492.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
HistoryPager: Make paging properties consistent with IndexPager typesTchandersmediawiki/extensions/Flowmaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Feb 12 2020, 12:51 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 12 2020, 12:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Feb 12 2020, 12:58 AM

Change 571611 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/Flow@master] HistoryPager: Make paging properties consistent with IndexPager types

https://gerrit.wikimedia.org/r/571611

gerritbot added a project: Patch-For-Review.Feb 12 2020, 12:58 AM
gerritbot added a comment.Feb 12 2020, 1:17 AM

Change 571611 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] HistoryPager: Make paging properties consistent with IndexPager types

https://gerrit.wikimedia.org/r/571611

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 12 2020, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 12 2020, 2:10 AM
Tchanders closed this task as Resolved.Feb 12 2020, 5:21 PM
Tchanders claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits