Page MenuHomePhabricator
Create Task
Maniphest T244981

Upgrade to wdio 5 for Wikibase repo browser tests
Closed, ResolvedPublic
Actions

Description

wdio 4 has repeatedly caused confusion with its waitForXYZ methods' behavior. Core and bridge are already running wdio 5, so it's about time.

Details

SubjectRepoBranchLines +/-
Upgrade browser tests to wdio 5mediawiki/extensions/WikibaseLexememaster+1 K -832
Upgrade to wdio 5mediawiki/extensions/Wikibasemaster+1 K -682
Prepare wdio5 upgradewikibase/termboxmaster+34 -24
Customize query in gerrit

Related Objects

Event Timeline

Jakob_WMDE created this task.Feb 12 2020, 10:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2020, 10:51 AM
Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 12 2020, 10:51 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Feb 12 2020, 11:15 AM
gerritbot added a comment.Feb 13 2020, 1:23 PM

Change 571969 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Prepare wdio5 upgrade

https://gerrit.wikimedia.org/r/571969

gerritbot added a project: Patch-For-Review.Feb 13 2020, 1:23 PM
gerritbot added a comment.Feb 13 2020, 4:43 PM

Change 572024 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Upgrade to wdio 5

https://gerrit.wikimedia.org/r/572024

Tarrow added a comment.EditedFeb 13 2020, 5:27 PM

Github PR is in.

Still presumably needs a release (probably with a major version bump). Don't want to tread on toes so I didn't start cutting one (but I can if you like) :)

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 18 2020, 10:15 AM
gerritbot added a comment.Feb 19 2020, 8:46 AM

Change 571969 merged by jenkins-bot:
[wikibase/termbox@master] Prepare wdio5 upgrade

https://gerrit.wikimedia.org/r/571969

Jakob_WMDE mentioned this in rWBTB02a0217ee2f9: Prepare wdio5 upgrade.Feb 19 2020, 8:53 AM
gerritbot added a comment.Feb 20 2020, 10:46 AM

Change 572024 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Upgrade to wdio 5

https://gerrit.wikimedia.org/r/572024

Tarrow moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 20 2020, 11:03 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 20 2020, 11:10 AM
Jakob_WMDE moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 20 2020, 11:34 AM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 21 2020, 5:11 PM
gerritbot added a comment.Feb 21 2020, 5:12 PM

Change 572914 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Upgrade browser tests to wdio 5

https://gerrit.wikimedia.org/r/572914

gerritbot added a project: Patch-For-Review.Feb 21 2020, 5:12 PM
gerritbot added a comment.Feb 23 2020, 9:32 AM

Change 572914 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Upgrade browser tests to wdio 5

https://gerrit.wikimedia.org/r/572914

Maintenance_bot removed a project: Patch-For-Review.Feb 23 2020, 10:10 AM
Jakob_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 24 2020, 10:17 AM
Addshore closed this task as Resolved.Mar 4 2020, 4:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL