Page MenuHomePhabricator

Incorporate new component library release in bridge
Closed, ResolvedPublic

Description

  • incl base font sizes for flexible components

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2020, 11:46 AM

Change 572247 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: update to new component library version

https://gerrit.wikimedia.org/r/572247

Change 572247 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: update to new component library version

https://gerrit.wikimedia.org/r/572247

Charlie_WMDE added a subscriber: Charlie_WMDE.

I found some inconsistencies with the specs:

the button should follow the specs of a Button Size M

The button on en.beta.wp:

  • has a font size of 16px with a line height of 24px but should be 14px with a line height of 21px
  • has spacing of 6px above and below the text but should be 4 above and 5 below
  • has a button height of 38px but should be 32px (should resolve itself when the line height and margins are fixed that i mentioned in the previous bullet points)

The component library is for the radio inputs – the buttons are unrelated. The adjustments you mention are currently part of T239421 and still in review (I4a8ecaea24).

Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 25 2020, 1:03 PM

Radio inputs verified – font sizes 16px and 14px, radio button 24×24px.