- incl base font sizes for flexible components
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| bridge: update to new component library version | mediawiki/extensions/Wikibase | master | +37 -37 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Charlie_WMDE | T243192 font size adjustments | |||
| Resolved | Lucas_Werkmeister_WMDE | T244992 Incorporate new component library release in bridge |
Event Timeline
Comment Actions
Change 572247 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: update to new component library version
Comment Actions
Change 572247 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: update to new component library version
Comment Actions
I found some inconsistencies with the specs:
the button should follow the specs of a Button Size M
The button on en.beta.wp:
- has a font size of 16px with a line height of 24px but should be 14px with a line height of 21px
- has spacing of 6px above and below the text but should be 4 above and 5 below
- has a button height of 38px but should be 32px (should resolve itself when the line height and margins are fixed that i mentioned in the previous bullet points)
Comment Actions
The component library is for the radio inputs – the buttons are unrelated. The adjustments you mention are currently part of T239421 and still in review (I4a8ecaea24).