Description

Add application state "saving"
apply to changed Initializing component (show it while saving)

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
bridge: guard getters against initializing lifecycle	mediawiki/extensions/Wikibase	master	+6 -6
bridge: test status getter aginst all options	mediawiki/extensions/Wikibase	master	+10 -2
bridge: Add ApplicationStatus "saving"	mediawiki/extensions/Wikibase	master	+74 -12

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Charlie_WMDE	T237433 Step 1: Loading bar for saving (impact: low)
		Resolved		• Tonina_Zhelyazkova_WMDE	T244999 Show saving is in progress

Event Timeline

• Pablo-WMDE created this task.Feb 12 2020, 12:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2020, 12:18 PM

• Pablo-WMDE moved this task from Incoming to Task overflow on the Wikidata-Bridge board.Feb 12 2020, 12:19 PM

• Tonina_Zhelyazkova_WMDE claimed this task.Feb 20 2020, 3:47 PM

• Tonina_Zhelyazkova_WMDE edited projects, added Wikidata-Bridge-Sprint-14; removed Wikidata-Bridge.

• Tonina_Zhelyazkova_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-14 board.

Change 573627 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Add ApplicationStatus "saving"

https://gerrit.wikimedia.org/r/573627

gerritbot added a project: Patch-For-Review.Feb 20 2020, 4:55 PM

Change 573627 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Add ApplicationStatus "saving"

https://gerrit.wikimedia.org/r/573627

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 21 2020, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2020, 5:10 PM

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-14 board.Feb 24 2020, 4:03 PM

Trying https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/573266 I encountered the funny behavior of an empty References section during saving.
Turns out there are some getters (e.g.) guard with the help of application Status but don't take into account that one of the options is now saving.

Change 574711 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: test status getter aginst all options

https://gerrit.wikimedia.org/r/574711

gerritbot added a project: Patch-For-Review.Feb 25 2020, 10:18 AM

Change 574711 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: test status getter aginst all options

https://gerrit.wikimedia.org/r/574711

Change 574725 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: guard getters against initializing lifecycle

https://gerrit.wikimedia.org/r/574725

Change 574725 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: guard getters against initializing lifecycle

https://gerrit.wikimedia.org/r/574725

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2020, 2:10 PM

• Pablo-WMDE added a project: Wikidata-Bridge-Sprint-15.Feb 26 2020, 9:44 AM

• Pablo-WMDE moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-15 board.

Lucas_Werkmeister_WMDE mentioned this in T246229: Add component for dialog with semi-opaque overlay.Feb 26 2020, 2:59 PM

Addshore moved this task from incoming to in progress on the Wikidata board.Feb 27 2020, 11:03 PM

• Tonina_Zhelyazkova_WMDE closed this task as Resolved.Feb 28 2020, 4:16 PM

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-15 board.