Page MenuHomePhabricator
Create Task
Maniphest T245043

Legacy methods WikiPage::clearPreparedEdit() and Article::clearPreparedEdit()
Open, LowPublic
Actions

Description

I'm mark as deprecated:

  • \WikiPage::$mPreparedEdit
  • \WikiPage::clearPreparedEdit
  • \Article::clearPreparedEdit

\MediaWiki\Edit\PreparedEdit also deprecated since 1.32 (2018-01-27)
It does not work or hasn't effect. I think we can remove that legacy code after deprecation

@tstarling says:
If you do this then you need to update Wikibase which uses this method. It seems to me that Wikibase was possibly broken by e8632ab0f6264851d2115a2e6338c2074b9a9b8c, i.e. the commit which caused clearPreparedEdit() to have no effect. Perhaps it was accidental that clearPreparedEdit() has no effect. Deprecating this method was not part of the referenced Phabricator task. I suggest splitting all changes to this file into a separate commit.

Details

SubjectRepoBranchLines +/-
Legacy methods WikiPage::clearPreparedEdit() and Article::clearPreparedEdit()mediawiki/extensions/Wikibasemaster+0 -5
Legacy methods WikiPage::clearPreparedEdit() and Article::clearPreparedEdit()mediawiki/coremaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Art-Baltai created this task.Feb 12 2020, 6:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2020, 6:00 PM
Art-Baltai moved this task from Backlog to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Feb 12 2020, 6:01 PM
Art-Baltai added a project: Patch-For-Review.
gerritbot added a comment.Feb 12 2020, 6:22 PM

Change 571777 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] Legacy methods WikiPage::clearPreparedEdit() and Article::clearPreparedEdit()

https://gerrit.wikimedia.org/r/571777

gerritbot added a comment.Feb 12 2020, 6:32 PM

Change 571779 had a related patch set uploaded (by Art-Baltai; owner: BAGArt):
[mediawiki/extensions/Wikibase@master] Legacy methods WikiPage::clearPreparedEdit() and Article::clearPreparedEdit()

https://gerrit.wikimedia.org/r/571779

Aklapper added projects: MediaWiki-General, Wikibase-DataModel.Feb 12 2020, 6:59 PM

@Art-Baltai: Adding project tags so others can find this task when searching for tasks under that project.

Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 12 2020, 7:00 PM
Art-Baltai mentioned this in T246867: Proposal after WikiPage/Article split.Mar 4 2020, 6:02 PM
Art-Baltai claimed this task.Mar 19 2020, 1:21 AM
Peter.ovchyn moved this task from In Progress/In Review to Blocked on the Platform Team Workboards (S&F Workboard) board.Apr 1 2020, 9:54 AM
Helga_sf moved this task from Blocked to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.May 6 2020, 2:34 PM
Helga_sf moved this task from Estimated/Estimation to Backlog on the Platform Team Workboards (S&F Workboard) board.
Addshore moved this task from incoming to in progress on the Wikidata board.Jun 9 2020, 9:13 AM
Helga_sf reassigned this task from Art-Baltai to Peter.ovchyn.Jun 23 2020, 4:25 PM
Peter.ovchyn removed Peter.ovchyn as the assignee of this task.Jul 7 2020, 1:45 PM
Helga_sf triaged this task as Low priority.Aug 28 2020, 11:15 AM
matej_suchanek removed a project: Wikibase-DataModel.Aug 28 2020, 11:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL