Page MenuHomePhabricator
Create Task
Maniphest T245052

Add correct ARIA tags to player UI
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Ensure player plays nicely with screen readers.

While Wikispeech and screen readers should be mutually exclusive we should consider a scenario where a wiki has Wikispeech enabled by default but a user visits it with their preferred screen reader.

In this scenario we should ensure that the Wikispeech elements do not interfere with the screen reader.

See a similar issue raised about Page Previes/Hovercards and Accessibility guide for developers

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add aria-label to settings icon in Wikispeech gadgetmediawiki/extensions/Wikispeechmaster+15 -4
Add Aria-labels on player buttonsmediawiki/extensions/Wikispeechmaster+52 -12
Customize query in gerrit

Related Objects

Event Timeline

Lokal_Profil created this task.Feb 12 2020, 7:33 PM
Restricted Application added a project: Wikispeech-Jobrunner. · View Herald TranscriptFeb 12 2020, 7:33 PM
Sebastian_Berlin-WMSE renamed this task from Ensure player plays nicely with screen readers to Add correct ARIA tags to player UI.Feb 19 2020, 11:14 AM
Sebastian_Berlin-WMSE added a parent task: T181780: Use OOUI for the player controls.
Sebastian_Berlin-WMSE updated the task description. (Show Details)
Sebastian_Berlin-WMSE moved this task from Incoming to Backlog on the Wikispeech-Jobrunner board.Feb 19 2020, 11:17 AM
Sebastian_Berlin-WMSE subscribed.

Also relevant for T243579: Add a pre-loaded trigger for Wikispeech.

Sebastian_Berlin-WMSE removed a parent task: T181780: Use OOUI for the player controls.May 6 2020, 9:02 AM
Sebastian_Berlin-WMSE moved this task from Backlog to Incoming on the Wikispeech-Jobrunner board.Feb 13 2025, 8:10 AM
Sebastian_Berlin-WMSE moved this task from Incoming to Backlog on the Wikispeech-Jobrunner board.Feb 13 2025, 10:48 AM
Sebastian_Berlin-WMSE added a comment.Feb 19 2025, 10:24 AM

We received feedback from a screen reader user who pointed out how important labels are.

Sebastian_Berlin-WMSE moved this task from Backlog to Proposed for next sprint on the Wikispeech-Jobrunner board.Feb 19 2025, 10:24 AM
Graham87 subscribed.Feb 23 2025, 3:12 PM
Viktoria_Hillerud_WMSE claimed this task.Feb 27 2025, 10:31 AM
Viktoria_Hillerud_WMSE moved this task from Proposed for next sprint to Sprint on the Wikispeech-Jobrunner board.
Viktoria_Hillerud_WMSE edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.
Viktoria_Hillerud_WMSE added a project: User-Viktoria_Hillerud_WMSE.
Viktoria_Hillerud_WMSE moved this task from Backlog to In progress on the Wikispeech-Jobrunner (Sprint) board.
Viktoria_Hillerud_WMSE moved this task from Backlog to This week on the User-Viktoria_Hillerud_WMSE board.
gerritbot added a comment.Feb 28 2025, 12:22 PM

Change #1123630 had a related patch set uploaded (by Viktoria Hillerud WMSE; author: Viktoria Hillerud WMSE):

[mediawiki/extensions/Wikispeech@master] Add Aria-labels on player buttons

https://gerrit.wikimedia.org/r/1123630

gerritbot added a project: Patch-For-Review.Feb 28 2025, 12:22 PM
Viktoria_Hillerud_WMSE moved this task from This week to Reviewing on the User-Viktoria_Hillerud_WMSE board.Mar 4 2025, 8:59 AM
Sebastian_Berlin-WMSE set the point value for this task to 8.Mar 6 2025, 10:12 AM
gerritbot added a comment.Mar 11 2025, 8:54 AM

Change #1123630 merged by jenkins-bot:

[mediawiki/extensions/Wikispeech@master] Add Aria-labels on player buttons

https://gerrit.wikimedia.org/r/1123630

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2025, 9:31 AM
Viktoria_Hillerud_WMSE moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.Mar 12 2025, 9:17 AM
Lokal_Profil closed this task as Resolved.Mar 19 2025, 10:22 AM

This adds to the weight of T389334: Release version 0.1.11. but does not require any particular dokumentation och communication.

Sebastian_Berlin-WMSE mentioned this in T389334: Release version 0.1.11..Mar 19 2025, 10:22 AM
Sebastian_Berlin-WMSE reopened this task as Open.May 28 2025, 7:27 AM
Sebastian_Berlin-WMSE edited projects, added Wikispeech-Jobrunner; removed Wikispeech-Jobrunner (Sprint).

Reusing this task for a small addition. The settings button for the gadget doesn't have an ARIA label.

Sebastian_Berlin-WMSE moved this task from Incoming to Proposed for next sprint on the Wikispeech-Jobrunner board.May 28 2025, 7:27 AM
Viktoria_Hillerud_WMSE changed the point value for this task from 8 to 2.May 28 2025, 9:26 AM
Viktoria_Hillerud_WMSE moved this task from Proposed for next sprint to Sprint on the Wikispeech-Jobrunner board.
Viktoria_Hillerud_WMSE edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.
Viktoria_Hillerud_WMSE moved this task from Done to In progress on the Wikispeech-Jobrunner (Sprint) board.Jun 2 2025, 7:08 AM
gerritbot added a comment.Jun 2 2025, 8:57 AM

Change #1152640 had a related patch set uploaded (by Viktoria Hillerud WMSE; author: Viktoria Hillerud WMSE):

[mediawiki/extensions/Wikispeech@master] Add aria-label to settings icon in Wikispeech gadget

https://gerrit.wikimedia.org/r/1152640

gerritbot added a project: Patch-For-Review.Jun 2 2025, 8:57 AM
Viktoria_Hillerud_WMSE mentioned this in T394034: Release version 0.1.12.Jun 2 2025, 1:49 PM
gerritbot added a comment.Jun 9 2025, 10:16 AM

Change #1152640 merged by jenkins-bot:

[mediawiki/extensions/Wikispeech@master] Add aria-label to settings icon in Wikispeech gadget

https://gerrit.wikimedia.org/r/1152640

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2025, 10:31 AM
Viktoria_Hillerud_WMSE moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.Jun 9 2025, 12:27 PM
Viktoria_Hillerud_WMSE closed this task as Resolved.Jun 11 2025, 8:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits