Page MenuHomePhabricator
Create Task
Maniphest T245061

Ensures aria-hidden elements do not contain focusable elements (.mw-navigation-hint )
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Navigate to main page
  2. Navigate till "Your Alerts" control and hit enter.
  3. Navigate till "Preferences" control and hit enter.
  4. Navigate till "User Profile " control and hit enter.

Actual Results:
.mw-navigation-hint is contains tabindex and aria-hidden is true

Expected Results:
.mw-navigation-hint is contains tabindex and aria-hidden should false

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
`aria-hidden="true"` elements must not contain focusable elementsAkinwale-microsoftmediawiki/coremaster+1 -2
Customize query in gerrit

Event Timeline

Akinwale-microsoft created this task.Feb 12 2020, 9:28 PM
Herald added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2020, 9:28 PM
Akinwale-microsoft updated the task description. (Show Details)Feb 12 2020, 11:38 PM
gerritbot added a comment.Feb 13 2020, 12:00 AM

Change 571811 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[mediawiki/core@master] Fix: aria-hidden=true elements must not contain focusble elements

https://gerrit.wikimedia.org/r/571811

gerritbot added a project: Patch-For-Review.Feb 13 2020, 12:00 AM
gerritbot added a comment.Feb 13 2020, 1:12 AM

Change 571811 merged by jenkins-bot:
[mediawiki/core@master] aria-hidden="true" elements must not contain focusable elements

https://gerrit.wikimedia.org/r/571811

Volker_E closed this task as Resolved.Feb 13 2020, 1:24 AM
Volker_E triaged this task as Medium priority.
Volker_E removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 13 2020, 2:00 AM
Aklapper added a project: MediaWiki-Core-Preferences.Feb 13 2020, 5:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits