Page MenuHomePhabricator

[wmf.19] Uncaught TypeError: Cannot read property 'toggle' of undefined
Open, Needs TriagePublicBUG REPORT

Description

On wmf.19 (not in wmf.18) and in betalabs, RecentChanges and Watchlist produce the following console error upon loading

Uncaught TypeError: Cannot read property 'toggle' of undefined
    
 at MwRcfiltersUiFilterTagMultiselectWidget.FilterTagMultiselectWidget.onChangeTags
 at MwRcfiltersUiFilterTagMultiselectWidget.OO.EventEmitter.emit 
 at MwRcfiltersUiFilterTagMultiselectWidget.OO.ui.mixin.GroupElement.clearItems

With the specific reference to this.emptyFilterMessage.toggle(this.isEmpty());

FilterTagMultiselectWidget.prototype.onChangeTags = function() {
                if (this.controller.isInitialized()) {
                    FilterTagMultiselectWidget.parent.prototype.onChangeTags.call(this);
                }
                this.emptyFilterMessage.toggle(this.isEmpty());
            }

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2020, 10:56 PM

Change 571822 had a related patch set uploaded (by Catrope; owner: Catrope):
[oojs/ui@master] MenuTagMultiselectWidget: Don't call setValue() if config.selected is empty

https://gerrit.wikimedia.org/r/571822

Change 571826 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: Create emptyFilterMessage before calling parent constructor

https://gerrit.wikimedia.org/r/571826

Change 571822 merged by jenkins-bot:
[oojs/ui@master] MenuTagMultiselectWidget: Don't call setValue() if config.selected is empty

https://gerrit.wikimedia.org/r/571822

Change 571826 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Create emptyFilterMessage before calling parent constructor

https://gerrit.wikimedia.org/r/571826

Need to backport?

I don't think it's all that urgent, because it doesn't seem to actually break anything. It throws a JS error on initialization, but no functionality appears to be broken.

RP88 added a subscriber: RP88.Feb 17 2020, 6:02 AM

Change 575115 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.37.0

https://gerrit.wikimedia.org/r/575115

Change 575115 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.37.0

https://gerrit.wikimedia.org/r/575115