[VisualEditor] Fix missing name(aria-label) in Page Options - Find and Replace
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Akinwale-microsoft
	Feb 12 2020, 11:37 PM

Project Tags

Referenced Files

None

Subscribers

Description

Steps to Reproduce:

Navigate to visual editor
navigate till "Page Options" and hit enter

3.Navigate till "Find And Replace" and hit enter

Actual Results:
Not every form element in FindAndReplace have a label associated.

Expected Results:
Ensures every form element has a label (label - https://dequeuniversity.com/rules/axe/3.3/label?application=msftAI)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Update VE core submodule to master (a5f81e9fb)	Bartosz Dziewoński	mediawiki/extensions/VisualEditor	master	+1 -1
	Fix: Added aria-label attribute to elements in find and replace dialog.	Akinwale-microsoft	VisualEditor/VisualEditor	master	+9 -0

Customize query in gerrit

Related Objects

Mentioned Here: rGVEDa5f81e9fb0fe: Merge "Fix: Add aria-label to comment inspector"

Event Timeline

Akinwale-microsoft created this task.Feb 12 2020, 11:37 PM

Herald added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2020, 11:37 PM

Change 571840 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[VisualEditor/VisualEditor@master] Fix: Added aria-label attribute to elements in find and replace dialog.

https://gerrit.wikimedia.org/r/571840

gerritbot added a project: Patch-For-Review.Feb 13 2020, 12:24 AM

Change 571840 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix: Added aria-label attribute to elements in find and replace dialog.

https://gerrit.wikimedia.org/r/571840

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2020, 1:10 AM

Change 572743 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a5f81e9fb)

https://gerrit.wikimedia.org/r/572743

gerritbot added a project: Patch-For-Review.Feb 17 2020, 8:39 PM

• matmarex added a project: Editing-team (Q3 2019-2020 Kanban Board).Feb 17 2020, 8:45 PM

• matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 17 2020, 8:46 PM

Change 572743 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a5f81e9fb)

https://gerrit.wikimedia.org/r/572743

• matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 17 2020, 8:56 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 17 2020, 9:10 PM