Page MenuHomePhabricator

Special:Watchlist: Filter out expired items [medium]
Closed, ResolvedPublic

Description

As a Watchlist Expiry user, I want expired items filtered out of Special:Watchlist, so that I only see items that I am currently watching in my watchlist.

Background: This work is similar to T245081: Special:EditWatchlist: Filter out expired items [medium]. We are doing this work to make sure that items that are expired but weren't yet purged will not be displayed. This functionality must be behind the feature flag for this product. This ticket is for back-end work only.

Acceptance Criteria:

  • When viewing Special:Watchlist, make sure that all items that are expired are filtered out of the list.

Event Timeline

Restricted Application added a project: archived--TCB-Team. · View Herald TranscriptFeb 13 2020, 12:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ifried updated the task description. (Show Details)Feb 13 2020, 5:08 PM
ifried updated the task description. (Show Details)Feb 13 2020, 5:12 PM
ifried updated the task description. (Show Details)Feb 13 2020, 5:44 PM
ifried updated the task description. (Show Details)Feb 13 2020, 5:51 PM
ARamirez_WMF renamed this task from Special:Watchlist: Filter out expired items to Special:Watchlist: Filter out expired items [medium].Feb 13 2020, 6:26 PM
ARamirez_WMF moved this task from To Be Estimated/Discussed to Estimated on the Community-Tech board.
Restricted Application edited projects, added Community-Tech; removed Community-Tech (Kanban-Q3-2019-20). · View Herald TranscriptFeb 13 2020, 6:55 PM

Note also you need to update all the count methods in WatchedItemStore, e.g. at the top of Special:Watchlist it says "You have N pages on your watchlist". That number should not include expired items.

HMonroy claimed this task.Feb 27 2020, 6:40 PM
HMonroy moved this task from Ready to In Development on the Community-Tech (Kanban-Q3-2019-20) board.

Change 592794 had a related patch set uploaded (by HMonroy; owner: HMonroy):
[mediawiki/core@master] Filter out expired items from Special:Watchlist page

https://gerrit.wikimedia.org/r/592794

Change 592794 merged by jenkins-bot:
[mediawiki/core@master] Filter out expired items from Special:Watchlist page

https://gerrit.wikimedia.org/r/592794

dom_walden added a subscriber: dom_walden.

Expired watchlist items no longer appear in Special:Watchlist.

I wrote a script to compare the output of Special:Watchlist with Special:RecentChanges (which shows the same changes), for a user with a mix of expired, temporary and permanently watched items. It detected no differences.

ifried closed this task as Resolved.Wed, Jun 10, 1:06 AM
ifried moved this task from Product sign-off to Done on the Community-Tech (Kanban-2019-20-Q4) board.
ifried added a subscriber: ifried.

I have tested this, and the watchlist filters out items that are no longer being watched. For this reason, I am marking this work as Done.