Improve message for Special:Investigate preliminary check when there are no results
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Feb 13 2020, 12:57 AM

Description

Goal

The message (in English) currently says "There are no results". The preliminary check displays data for any users added, but not for any IPs. Therefore, there may be no results for the preliminary check, but some results for the Compare and Timeline tabs. The message should make clear that it may still be worth looking at the other tabs if there are no results in the preliminary check.

Acceptance criteria

If there is an IP address queried for, in the Preliminary Check tab, add an info message (design below) to indicate that the P.C. table does not show information for IPs.

If the search only comprises of IP addresses, do not display a table, only display the info message.
The words "Compare tab" link to the Compare tab.

Details

Due Date: Feb 28 2020, 8:00 AM

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/CheckUser	master	+53 -11	Improve message for preliminary check when an IP is entered

Customize query in gerrit

Event Timeline

Tchanders created this task.Feb 13 2020, 12:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2020, 12:57 AM

Assuming this task is about CheckUser, hence adding project tag so others can find this task when searching for tasks under that project. Please don't only add some group/team tags when a task is also about a code base - thanks a lot! :)

Thanks for the task, @Tchanders. I updated the description with the mock.

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Feb 13 2020, 6:38 PM

Niharika updated the task description. (Show Details)Feb 20 2020, 7:20 PM

Niharika set the point value for this task to 1.Feb 20 2020, 7:22 PM

Niharika moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Feb 20 2020, 7:36 PM

Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Feb 20 2020, 9:13 PM

Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Niharika set Due Date to Feb 28 2020, 8:00 AM.Feb 20 2020, 10:26 PM

Tchanders claimed this task.Feb 24 2020, 2:54 PM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 574512 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] Improve message for preliminary check when an IP is entered

https://gerrit.wikimedia.org/r/574512

gerritbot added a project: Patch-For-Review.Feb 24 2020, 5:46 PM

@Niharika I couldn't see an example of a message widget with the blue colour: https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#MessageWidget-type-notice (perhaps @Mooeypoo could confirm whether this is the case?)

For the current patch, I've used the 'notice' type (rather than the 'warning' type). Do you think that's the most appropriate type for this case?

Screenshot:

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 24 2020, 5:49 PM

Change 574512 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Improve message for preliminary check when an IP is entered

https://gerrit.wikimedia.org/r/574512

dbarratt moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Feb 25 2020, 4:44 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 25 2020, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2020, 5:10 PM

Searching just for IPs:

Just usernames:

Both:

If no results for username (e.g. user does not have global account) then just There are no results. is displayed.

I checked that the link in the message is the same as the link to the "Compare" tab.

dbarratt closed this task as Resolved.Feb 26 2020, 2:27 PM

	F31631786: just_ip.png
	Feb 26 2020, 11:59 AM

	F31631788: just_username.png
	Feb 26 2020, 11:59 AM

	F31631790: both_username_ip.png
	Feb 26 2020, 11:59 AM

	F31629513: image.png
	Feb 24 2020, 5:48 PM

Improve message for Special:Investigate preliminary check when there are no resultsClosed, ResolvedPublic1 Estimated Story PointsActions