Page MenuHomePhabricator

Improve message for Special:Investigate preliminary check when there are no results
Closed, ResolvedPublic1 Estimated Story Points

Description

Goal

The message (in English) currently says "There are no results". The preliminary check displays data for any users added, but not for any IPs. Therefore, there may be no results for the preliminary check, but some results for the Compare and Timeline tabs. The message should make clear that it may still be worth looking at the other tabs if there are no results in the preliminary check.

Acceptance criteria

  • If there is an IP address queried for, in the Preliminary Check tab, add an info message (design below) to indicate that the P.C. table does not show information for IPs.

image.png (383×1 px, 55 KB)

  • If the search only comprises of IP addresses, do not display a table, only display the info message.
  • The words "Compare tab" link to the Compare tab.

Event Timeline

Assuming this task is about CheckUser, hence adding project tag so others can find this task when searching for tasks under that project. Please don't only add some group/team tags when a task is also about a code base - thanks a lot! :)

Niharika triaged this task as Medium priority.Feb 13 2020, 6:38 PM
Niharika updated the task description. (Show Details)
Niharika added a subscriber: Niharika.

Thanks for the task, @Tchanders. I updated the description with the mock.

Niharika set the point value for this task to 1.Feb 20 2020, 7:22 PM
Niharika set Due Date to Feb 28 2020, 8:00 AM.Feb 20 2020, 10:26 PM

Change 574512 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] Improve message for preliminary check when an IP is entered

https://gerrit.wikimedia.org/r/574512

@Niharika I couldn't see an example of a message widget with the blue colour: https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#MessageWidget-type-notice (perhaps @Mooeypoo could confirm whether this is the case?)

For the current patch, I've used the 'notice' type (rather than the 'warning' type). Do you think that's the most appropriate type for this case?

Screenshot:

image.png (316×813 px, 38 KB)

Change 574512 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Improve message for preliminary check when an IP is entered

https://gerrit.wikimedia.org/r/574512

dom_walden added a subscriber: dom_walden.

Searching just for IPs:

just_ip.png (243×872 px, 14 KB)

Just usernames:

just_username.png (261×1 px, 19 KB)

Both:

both_username_ip.png (327×1 px, 26 KB)

If no results for username (e.g. user does not have global account) then just There are no results. is displayed.

I checked that the link in the message is the same as the link to the "Compare" tab.