Page MenuHomePhabricator

Character recommendation validator
Open, MediumPublicFeature

Description

For Kiwix, we recently had a few lintings errors with exported translations, due to the following,

  • Replace straight quotes with directional quotes
  • Hyphen can be replaced with m-dash
  • Ellipsis string can be replaced with ellipsis character

Source: https://github.com/kiwix/kiwix-android/pull/1590#issuecomment-576245097

The occurrences of this could be resolved, if we add a RecommendationValidator, that when translators use a certain set of characters... it recommends them to replace it with another set. This validator could also be made insertable.

Note that these should not be added for all languages, and only for certain languages. This means we've to update the validator framework, to take as input, the languages that have to be skipped. See - https://github.com/kiwix/kiwix-android/issues/1711

Event Timeline

abi_ renamed this task from Character recommendation translator to Character recommendation validator.Feb 13 2020, 6:59 AM
abi_ triaged this task as Medium priority.
abi_ created this task.
Nikerabbit changed the subtype of this task from "Task" to "Feature Request".Nov 23 2020, 4:08 PM

@abi_ Does ReplacementValidator cover this use case?

@abi_ Does ReplacementValidator cover this use case?

Yes this would fulfill the needs of this task although we don't have insertables with the ReplacementValidator. I or @Wangombe will submit a patch.