Page MenuHomePhabricator

Remove deprecated code from SpecialPageFactory
Open, Needs TriagePublic

Description

Motivation

At the moment there's a deprecated logic exists in SpecialPageFactory.php that can be safely removed

	if ( $rec instanceof SpecialPage ) {
				wfDeprecated(
					"a SpecialPage instance (for $realName) in " .
					'$wgSpecialPages or from the SpecialPage_initList hook',
					'1.34'
				);

				$page = $rec; // XXX: we should deep clone here
			}

Expected Result:

The occurance above should be removed.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2020, 9:58 AM
Peter.ovchyn updated the task description. (Show Details)Feb 13 2020, 9:59 AM

@Peter.ovchyn: Assuming this task is about the MediaWiki-Special-pages code base, hence adding project tag so other people who don't know or don't care about random team tags can find this task when searching for tasks.