Page MenuHomePhabricator

VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model
Open, Needs TriagePublicBUG REPORT

Description

There should be no such thing as visual mode for diffs of non-wikitext pages. So these buttons should be hidden.

Steps to Reproduce:

Results:

The two toggle buttons unexpectedly appear in the mobile diff page while they are missing from the desktop diff page.

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedppelberg
ResolvedKrinkle
OpenNone
OpenNone
OpenNone
OpenHalfak
OpenNone
OpenNone
StalledNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedPetrb
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedovasileva
Resolvedmarcella
OpenBUG REPORTNone
Resolvedovasileva

Event Timeline

Masumrezarock100 removed marcella as the assignee of this task.Feb 13 2020, 4:55 PM
Masumrezarock100 created this task.
Masumrezarock100 added a subscriber: marcella.

I did not see any toggle buttons.

I did not see any toggle buttons.

Have you enabled the VisualDiff beta feature?

I did not see any toggle buttons.

Have you enabled the VisualDiff beta feature?

I followed what "Steps to Reproduce" says. So that condition should be added there

Masumrezarock100 added a comment.EditedFeb 13 2020, 7:34 PM

I said this is about the VisualDiff extension. One can not see the buttons and use it unless they enable the beat feature in their preferences. That much should have been obvious. Regardless, I have now updated the task description to avoid any unnecessary confusion in future.

This is a bug in MobileFrontend. It looks like it passes "Special:MobileDiff" as the page title to the diff engine, rather than the real title of the page, so we have no way to detect the visual diff should be disabled.

I suggest Readers-Web-Backlog to look into it since this appears to be a MF bug.
(I really hope Special:MobileDiff page will be removed and MF will use the core diff url. Current special:mobilediff creates a lot of problems for users.)

Current special:mobilediff creates a lot of problems for users.)

And desktop has traditionally causes a lot of problems for mobile users so that's why we are in this situation.

I really hope Special:MobileDiff page will be removed and MF will use the core diff url

That is the goal but is at least a six month project (if we're focused). I've began making several changes to push us in that direction in my volunteer time, but we're far from there. I currently have no partner in crime to speed that up.

I suggest Readers-Web-Backlog to look into it since this appears to be a MF bug.

Tracking is sufficient here. Readers Web are currently focused on desktop improvements so we're not going to get to this any time soon. VisualDiffs is currently only a beta feature so this particular issue impacts very few users which is why on a previous patchset I suggested the feature was hidden.

Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 15 2020, 12:29 AM
Masumrezarock100 added a comment.EditedFeb 15 2020, 12:44 AM

Tracking is sufficient here. Readers Web are currently focused on desktop improvements so we're not going to get to this any time soon. VisualDiffs is currently only a beta feature so this particular issue impacts very few users which is why on a previous patchset I suggested the feature was hidden.

I agree with you. If the product owner of this feature agrees, it should be hidden on mobile. I am not sure if there is much demand for this feature on mobile (I haven't heard anyone asking for this, nor I found any prior phab tasks to enable it on mobile). Simply put, there are too many problems here, so I don't believe this is ready for production yet. The biggest one is the layout issue. The VisualDiff style currently doesn't match the unified diff style on mobile.

Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.