FlaggedRevs uses hard deprecated ArticleEditUpdates hook
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Feb 13 2020, 5:12 PM

Description

FlaggedRevsHooks::onArticleEditUpdates still exists

Should be replace with RevisionDataUpdates

Details

	Subject	Repo	Branch	Lines +/-
	Move to "RevisionDataUpdates" hook instead of "ArticleEditUpdates"	mediawiki/extensions/FlaggedRevs	master	+20 -15
	Replace use of ArticleEditUpdates hook with RevisionDataUpdates	mediawiki/extensions/FlaggedRevs	master	+66 -16

Customize query in gerrit

Related Objects

Mentioned In: T245725: ArticleEditUpdates deprecation log from FlaggedRevsHooks::onArticleEditUpdates spamming logs

Event Timeline

DannyS712 created this task.Feb 13 2020, 5:12 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 13 2020, 5:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Patch at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/571392/ already in progress

Change 571392 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/FlaggedRevs@master] Replace use of ArticleEditUpdates hook with RevisionDataUpdates

https://gerrit.wikimedia.org/r/571392

Jdforrester-WMF triaged this task as Low priority.Feb 14 2020, 8:19 PM

Change 571392 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Replace use of ArticleEditUpdates hook with RevisionDataUpdates

https://gerrit.wikimedia.org/r/571392

DannyS712 closed this task as Resolved.Feb 16 2020, 3:12 AM

DannyS712 removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 16 2020, 4:00 AM

DannyS712 moved this task from Others to Resolved tasks (others) on the User-DannyS712 board.Feb 18 2020, 10:27 PM

DannyS712 mentioned this in T245725: ArticleEditUpdates deprecation log from FlaggedRevsHooks::onArticleEditUpdates spamming logs.Feb 20 2020, 10:18 AM

Change 522377 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/extensions/FlaggedRevs@master] Move to "RevisionDataUpdates" hook instead of "ArticleEditUpdates"

https://gerrit.wikimedia.org/r/522377

Change 522377 abandoned by Krinkle:
Move to "RevisionDataUpdates" hook instead of "ArticleEditUpdates"

Reason:
Superseded. There is some refactoring here though that could perhaps be submitted entirely, but depends, this repo isn't actively maintained so unless urgent there wouldn't be anyone to review/test it.