Cascade-protecting files should protect the file, not the description page
OpenPublic

Description

Author: happy.melon.wiki

Description:
Currently inlining an image on a cascade-protected page protects the image, which is good. Bug 6579 introduces functionality that allows only the file to be protected, not the description page. Only changes which actually affect the cascade-protected page should be prevented, which in this case means changing the file pointed to. So cascade protection of inlined images should be to protect the file, not the description page.


Version: unspecified
Severity: normal

bzimport added a subscriber: Unknown Object (MLST).
bzimport set Reference to bz22521.
bzimport created this task.Via LegacyFeb 14 2010, 6:58 PM
ToAruShiroiNeko added a comment.Via ConduitApr 20 2012, 5:27 PM

See: http://commons.wikimedia.org/wiki/Commons:Village_pump#Cascade_protection_of_Main_Page

I feel cascade protection is a problem for Commons where it is impossible to modify the file description page of the highlighted file.

This prevents possible improvements such as categorization of the file, translation of file description, update of assessments template (to match WMF blog).

bzimport added a comment.Via ConduitApr 20 2012, 6:17 PM

saibotrash wrote:

The cascade protection may be used to protect the file descs, too. I think it would be stupid if the behavior would change after several years (for some users).

Maybe a new option should be there: "except file descs from cascade protection"([edit=<unaffected>] just move and upload cascaded). The cascade protection only would need to apply to upload and move.

Ciencia_Al_Poder added a comment.Via ConduitApr 20 2012, 7:27 PM

Saibo: The reason for cascade protection existence is to protect the page and everything that it's included on the page from being changed. Templates are protected because their contents are transcluded on the page. Since editing the template would change the contents of the article, cascade protection prevents the edition of the template contents. For images/files, what it's included in the page is the image itself, not the description, so the upload or revert of versions of the image should be prevented. Uploading a new version of a file is like editing a transcluded template. There's no point in prevent the edition of the file description since editing it won't affect the protected page in any way.

If you want file descriptions to be protected just transclude them on the protected page, like {{:File:Example.png}}. That would be consistent with other namespaces. Otherwise I don't see any point in using cascade protect just for file description pages.

Ciencia_Al_Poder awarded a token.Via WebDec 31 2014, 3:54 PM
Steinsplitter awarded a token.Via WebJan 2 2015, 5:29 PM
SJu added a subscriber: SJu.Via WebJul 11 2015, 2:49 AM
zhuyifei1999 added a subscriber: zhuyifei1999.Via WebTue, Aug 18, 1:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptVia HeraldTue, Aug 18, 1:00 PM
zhuyifei1999 added a comment.Via WebTue, Aug 18, 2:25 PM

Related: T62109; transclusion doesn't cascade protect properly.

Nemo_bis added a comment.Via WebSun, Aug 23, 8:04 AM

This sounds blocked on T10658, which should IMHO fixed but was declined.

zhuyifei1999 added a comment.Via WebSun, Aug 23, 9:16 AM

This sounds blocked on T10658, which should IMHO fixed but was declined.

I don't see how they are related. A cascade-protected page such as a main page should protect the used files properly (and not the file description pages), whether the main page is under full or semi-protection.

Nemo_bis added a comment.Via WebSun, Aug 23, 12:23 PM

I don't see how they are related.

The relation is that AFAICS by editing a cascade-protected file's description one could protect further files without being sysop, the same scenario.

zhuyifei1999 added a comment.Via WebSun, Aug 23, 1:24 PM

The relation is that AFAICS by editing a cascade-protected file's description one could protect further files without being sysop, the same scenario.

Nah ;) There's no recursion in cascade protect detection. What it matters is which cascade-protected pages actually has an *image link* to the file (via imagelinks table). You can't modify that with a file description page, can you?

I'll submit a patch for T109435 in a few minutes, when I finish the commit message.

gerritbot added a subscriber: gerritbot.Via ConduitSun, Aug 23, 1:57 PM

Change 233207 had a related patch set uploaded (by Zhuyifei1999):
Cascade-protection: Fixes for files

https://gerrit.wikimedia.org/r/233207

gerritbot added a project: Patch-For-Review.Via ConduitSun, Aug 23, 1:57 PM
Krenair added a subscriber: Krenair.Via WebSun, Aug 23, 3:14 PM
zhuyifei1999 added a project: user-notice.Via WebTue, Aug 25, 12:20 PM
Johan moved this task to Not ready to announce on the user-notice workboard.Via WebThu, Aug 27, 4:40 PM

Add Comment