Page MenuHomePhabricator
Create Task
Maniphest T245250

Review MinervaNeue Selenium tests
Open, Needs TriagePublic
Actions

Description

Pair with @Edtadros on reviewing MinervaNeue Selenium tests.

Code: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/MinervaNeue/%2B/master/tests/selenium/

Jenkins job: https://integration.wikimedia.org/ci/job/selenium-daily-beta-Minerva/

TODO

  • write several new tests
  • review and rewrite tests from specs folder
  • review and rewrite tests from features folder
  • update wdio.conf.js to add video recording, see T210726 and P8625

Details

SubjectRepoBranchLines +/-
WIP Selenium: Sections should be visible when going to a page with a hash in the URLmediawiki/skins/MinervaNeuemaster+1 K -2 K
Selenium: record videos of all testsmediawiki/skins/MinervaNeuemaster+73 -9
Add Ed Tadros to receive mail for selenium-daily-beta-Minervaintegration/configmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Feb 14 2020, 12:57 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptFeb 14 2020, 12:57 PM
zeljkofilipin triaged this task as Medium priority.Feb 14 2020, 12:57 PM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added a parent task: T174018: Port Minerva's 7 Ruby-based browser tests to Selenium Node.js.
zeljkofilipin updated the task description. (Show Details)Feb 14 2020, 5:24 PM
gerritbot added a comment.Feb 18 2020, 5:57 PM

Change 572929 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/skins/MinervaNeue@master] WIP Selenium: record videos of all tests

https://gerrit.wikimedia.org/r/572929

gerritbot added a project: Patch-For-Review.Feb 18 2020, 5:57 PM
zeljkofilipin mentioned this in T246881: +2 for Edtadros for mediawiki/skins/MinervaNeue.Mar 4 2020, 10:41 AM
zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.Mar 10 2020, 3:11 PM
gerritbot added a comment.Mar 11 2020, 10:55 PM

Change 572929 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Selenium: record videos of all tests

https://gerrit.wikimedia.org/r/572929

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 11 2020, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 11 2020, 11:10 PM
zeljkofilipin added a subtask: T246881: +2 for Edtadros for mediawiki/skins/MinervaNeue.Mar 12 2020, 12:39 PM
zeljkofilipin moved this task from Deep work 🌊 to Learn/Teach 💡 on the User-zeljkofilipin board.Mar 18 2020, 2:29 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Mar 26 2020, 5:31 PM
zeljkofilipin moved this task from Learn/Teach 💡 to Waiting 🏹 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Waiting 🏹 to Deep work 🌊 on the User-zeljkofilipin board.Apr 8 2020, 2:33 PM
zeljkofilipin claimed this task.Apr 9 2020, 3:28 PM
gerritbot added a comment.Apr 14 2020, 2:42 PM

Change 588711 had a related patch set uploaded (by Edward Tadros; owner: Edward Tadros):
[integration/config@master] Add Ed Tadros to receive mail for selenium-daily-beta-Minerva

https://gerrit.wikimedia.org/r/588711

gerritbot added a project: Patch-For-Review.Apr 14 2020, 2:42 PM
gerritbot added a comment.Apr 14 2020, 3:02 PM

Change 588711 merged by jenkins-bot:
[integration/config@master] Add Ed Tadros to receive mail for selenium-daily-beta-Minerva

https://gerrit.wikimedia.org/r/588711

Maintenance_bot removed a project: Patch-For-Review.Apr 14 2020, 3:11 PM
zeljkofilipin updated the task description. (Show Details)Apr 30 2020, 3:41 PM
zeljkofilipin updated the task description. (Show Details)Apr 30 2020, 3:45 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added a subtask: T251543: MinervaNeue Selenium tests fail when targeting MediaWiki-Docker.Apr 30 2020, 4:52 PM
zeljkofilipin reassigned this task from zeljkofilipin to Edtadros.May 5 2020, 3:30 PM
gerritbot added a comment.May 5 2020, 4:02 PM

Change 594515 had a related patch set uploaded (by Edward Tadros; owner: Edward Tadros):
[mediawiki/skins/MinervaNeue@master] WIP Selenium: Sections should be visible when going to a page with a hash in the URL

https://gerrit.wikimedia.org/r/594515

gerritbot added a project: Patch-For-Review.May 5 2020, 4:02 PM
zeljkofilipin moved this task from Deep work 🌊 to Learn/Teach 💡 on the User-zeljkofilipin board.May 25 2020, 2:01 PM
zeljkofilipin moved this task from Learn/Teach 💡 to Project ♟ on the User-zeljkofilipin board.
zeljkofilipin closed subtask T251543: MinervaNeue Selenium tests fail when targeting MediaWiki-Docker as Resolved.Jul 9 2020, 11:41 AM
zeljkofilipin mentioned this in T262617: Minerva Selenium test for talk page creation was disabled (Can't call getText on element with selector ".section-heading" because element wasn't found).Sep 23 2020, 11:58 AM
zeljkofilipin moved this task from Project ♟ to Waiting 🏹 on the User-zeljkofilipin board.Oct 15 2020, 4:02 PM
zeljkofilipin added a comment.Dec 22 2020, 6:56 PM

@Edtadros do you still want to do this?

Edtadros added a comment.Dec 22 2020, 7:00 PM

@zeljkofilipin we probably still should. I'll ping you on slack to set something up.

zeljkofilipin added a comment.Dec 23 2020, 12:08 PM

👍

zeljkofilipin awarded a token.Dec 23 2020, 12:08 PM

Double thumbs up. 😬

zeljkofilipin mentioned this in T272142: Mentor coworkers, volunteers and interns.Jan 15 2021, 12:43 PM
zeljkofilipin closed subtask T246881: +2 for Edtadros for mediawiki/skins/MinervaNeue as Resolved.May 6 2021, 4:58 PM
gerritbot added a comment.Jun 11 2021, 4:04 PM

Change 594515 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] WIP Selenium: Sections should be visible when going to a page with a hash in the URL

Reason:

https://gerrit.wikimedia.org/r/594515

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2021, 4:10 PM
zeljkofilipin removed a project: Quality-and-Test-Engineering-Team.Sep 16 2021, 10:27 AM
zeljkofilipin added a project: Browser-Tests.Oct 7 2021, 11:27 AM
zeljkofilipin moved this task from Waiting 🏹 to Backlog 🪒 on the User-zeljkofilipin board.
zeljkofilipin added a project: MinervaNeue.Oct 7 2021, 6:03 PM
Jdlrobson subscribed.Apr 6 2022, 10:36 PM

I think this can be resolved?

zeljkofilipin added a comment.Apr 7 2022, 11:43 AM

@Jdlrobson As far as I understood, this task is about reviewing and updating existing MinervaNeue selenium tests. If @Edtadros is happy with the current test suite, then this can be resolved, as far as I'm concerned.

zeljkofilipin moved this task from Backlog 🪒 to Waiting 🏹 on the User-zeljkofilipin board.Apr 7 2022, 11:44 AM
zeljkofilipin moved this task from Waiting 🏹 to Watching 📺 on the User-zeljkofilipin board.Apr 29 2022, 12:18 PM
Aklapper removed Edtadros as the assignee of this task.Sep 26 2022, 10:31 AM

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

zeljkofilipin raised the priority of this task from Medium to Needs Triage.Oct 31 2023, 4:25 PM
zeljkofilipin moved this task from Watching 📺 to Backlog 🪒 on the User-zeljkofilipin board.Nov 14 2023, 3:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL