Page MenuHomePhabricator

Pull Request builds in Travis should check for merge against target branch instead of always using master
Closed, ResolvedPublic

Description

We have Pull Request testing set up via Travis CI, however our configuration is set up to test against the master branch by default. If we want to merge PRs into other branches this doesn't work correctly. We should be identifying the target branch and using that for merge testing.

This task may change, or not be required, if we move to Github Actions instead of Travis: T245256

Event Timeline

Samwalton9 triaged this task as Medium priority.Feb 14 2020, 1:19 PM
Samwalton9 updated the task description. (Show Details)

It appears that this was some kind of transient issue. I just checked a recent build for a pr against staging, and it appears to have correctly built for staging and not master. It looks like the build status isn't always being shown in GitHub though. Sometimes the CI check shows, and sometimes it doesn't. When this happens, it will simply show the WIP check as pass/fail.

Samwalton9 claimed this task.

I'll mark this as resolved then :)