Page MenuHomePhabricator
Create Task
Maniphest T245266

Add a shell script linter
Open, LowestPublic
Actions

Description

We're now linting our Python code, but not doing anything to check our shell scripts. We could implement something like ShellCheck to do so.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT240153 Address project technical debt
 OpenNoneT245266 Add a shell script linter

Event Timeline

Samwalton9-WMF created this task.Feb 14 2020, 1:52 PM
Samwalton9-WMF triaged this task as Lowest priority.
Samwalton9-WMF moved this task from Incoming tasks to Open tasks on the Library-Card-Platform board.Jun 5 2020, 10:35 AM
hashar subscribed.Jun 5 2020, 3:35 PM

We had a generic task to add shellcheck to Wikimedia CI at T148494

Eventually the SRE team is working on adding it to their primary repository (operations/puppet.git) via T254480. From the experience learned there, I guess we can then easily generalize it to the rest of the repositories.

Samwalton9-WMF moved this task from Open tasks to Incoming tasks on the Library-Card-Platform board.Oct 1 2020, 9:03 AM
Dzahn mentioned this in T200984: Stop introducing new code expanded from erb templates.Oct 3 2020, 12:11 AM
Samwalton9-WMF added a project: The-Wikipedia-Library.Jan 21 2021, 10:50 AM
Samwalton9-WMF moved this task from Backlog to Technical debt on the The-Wikipedia-Library board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits