Page MenuHomePhabricator
Create Task
Maniphest T245293

Remove $wgAllowImageMoving
Closed, ResolvedPublic
Actions

Description

An outdated setting that may be replaced by $wgGroupPermissions.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+8 -29Remove $wgAllowImageMoving, deprecated
mediawiki/coremaster+15 -0Deprecate setting `$wgAllowImageMoving` to false
operations/mediawiki-configmaster+0 -6Remove use of `wgAllowImageMoving`
Customize query in gerrit

Related Objects

Event Timeline

Bugreporter created this task.Feb 14 2020, 7:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2020, 7:04 PM
DannyS712 claimed this task.Feb 14 2020, 7:10 PM
DannyS712 triaged this task as Low priority.
DannyS712 moved this task from Unsorted to Needs removal on the Technical-Debt board.
DannyS712 added a subscriber: DannyS712.

Probably needs to be deprecated first:

  • 1.35: Add hard deprecation for setting to false
  • 1.36: Remove entirely
Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 14 2020, 7:10 PM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Feb 14 2020, 7:10 PM
Reedy added a subscriber: Reedy.Feb 15 2020, 12:11 AM

Noting there is already a 'movefile' right anyway....

Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Feb 20 2020, 4:31 AM
DannyS712 edited projects, added MediaWiki-Configuration; removed MediaWiki-General.Apr 27 2020, 6:03 AM
gerritbot added a comment.Apr 27 2020, 6:05 AM

Change 592518 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[operations/mediawiki-config@master] Remove use of wgAllowImageMoving

https://gerrit.wikimedia.org/r/592518

gerritbot added a project: Patch-For-Review.Apr 27 2020, 6:05 AM
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Apr 27 2020, 6:06 AM
DannyS712 moved this task from Next to In progress on the User-DannyS712 board.
DannyS712 added a comment.Apr 27 2020, 5:51 PM
In T245293#6083407, @gerritbot wrote:

Change 592518 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[operations/mediawiki-config@master] Remove use of wgAllowImageMoving

https://gerrit.wikimedia.org/r/592518

Scheduled for swat: Monday, April 27 18:00–19:00 UTC Morning SWAT

gerritbot added a comment.Apr 27 2020, 6:08 PM

Change 592518 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove use of wgAllowImageMoving

https://gerrit.wikimedia.org/r/592518

Stashbot added a comment.Apr 27 2020, 6:10 PM

Mentioned in SAL (#wikimedia-operations) [2020-04-27T18:10:25Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: 8b71f38: Remove use of wgAllowImageMoving (T245293) (duration: 00m 57s)

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2020, 6:13 PM
gerritbot added a comment.Jun 6 2020, 4:26 AM

Change 602792 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Deprecate setting $wgAllowImageMoving to false

https://gerrit.wikimedia.org/r/602792

gerritbot added a project: Patch-For-Review.Jun 6 2020, 4:26 AM
gerritbot added a comment.Jun 9 2020, 12:35 AM

Change 602792 merged by jenkins-bot:
[mediawiki/core@master] Deprecate setting $wgAllowImageMoving to false

https://gerrit.wikimedia.org/r/602792

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 9 2020, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 9 2020, 1:10 AM
DannyS712 changed the task status from Open to Stalled.Jun 9 2020, 1:57 AM
DannyS712 moved this task from In progress to Later on the User-DannyS712 board.

Cannot be removed until 1.36

Legoktm changed the task status from Stalled to Open.Jul 24 2020, 11:10 PM
Legoktm added a subscriber: Legoktm.

IIRC this was a feature flag from back when image moving was unstable but that's no longer the case.

Legoktm moved this task from Backlog to In Progress on the MediaWiki-Configuration board.Jul 24 2020, 11:11 PM
gerritbot added a comment.Sep 14 2020, 1:01 AM

Change 626902 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove $wgAllowImageMoving, deprecated

https://gerrit.wikimedia.org/r/626902

gerritbot added a project: Patch-For-Review.Sep 14 2020, 1:01 AM
DannyS712 moved this task from Later to Awaiting review and deployment on the User-DannyS712 board.Sep 14 2020, 1:04 AM
gerritbot added a comment.Sep 14 2020, 9:51 AM

Change 626902 merged by jenkins-bot:
[mediawiki/core@master] Remove $wgAllowImageMoving, deprecated

https://gerrit.wikimedia.org/r/626902

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 14 2020, 10:00 AM
DannyS712 closed this task as Resolved.Sep 14 2020, 11:37 AM
DannyS712 removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL