Unify SVG optimization to Wikimedia coding conventions in MobileFrontend and Minerva
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Feb 14 2020, 7:52 PM

Project Tags

Referenced Files

	F31667209: Screen Shot 2020-03-05 at 8.52.50 AM.png
	Mar 5 2020, 5:23 PM

	F31667208: Screen Shot 2020-03-05 at 9.02.36 AM.png
	Mar 5 2020, 5:23 PM

	F31667216: Screen Shot 2020-03-05 at 9.15.07 AM.png
	Mar 5 2020, 5:23 PM

	F31667205: Screen Shot 2020-03-05 at 9.02.16 AM.png
	Mar 5 2020, 5:23 PM

	F31667207: Screen Shot 2020-03-05 at 9.03.35 AM.png
	Mar 5 2020, 5:23 PM

	F31667206: Screen Shot 2020-03-05 at 8.55.40 AM.png
	Mar 5 2020, 5:23 PM

Subscribers

Description

MF/MN's SVGO rules contain

- collapseGroups: false
- mergePaths: false

which seem to have been introduced in I7b09e8 and since them never been revisited on possible rendering issues.
The conventions in https://www.mediawiki.org/wiki/Manual:Coding_conventions/SVG#Exemplified_safe_configuration provided widely proofed harmless optimizations.

QA

Visit https://en.m.wikipedia.org/wiki/Front_end in older Grade A browsers like IE 11 and look out for icons being visually correct, not having rendering issues. Both as logged-in and logged-out user as some icons are login-state specific.

QA Results

AC	Status	Details
1	❓	T245296#5945501
2	❌	T245296#5945501

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Unify SVGO rules to Wikimedia coding conventions and re-crush SVGs	VolkerE	mediawiki/skins/MinervaNeue	master	+24 -46
	Unify SVGO rules to Wikimedia coding conventions and re-crush SVGs	VolkerE	mediawiki/extensions/MobileFrontend	master	+0 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Volker_E	T178867 [EPIC] Unify and optimize SVG markup across Foundation products
		Resolved		Volker_E	T245296 Unify SVG optimization to Wikimedia coding conventions in MobileFrontend and Minerva

Event Timeline

Volker_E created this task.Feb 14 2020, 7:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2020, 7:52 PM

Change 572305 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Unify SVGO rules to Wikimedia coding conventions and re-crush SVGs

https://gerrit.wikimedia.org/r/572305

gerritbot added a project: Patch-For-Review.Feb 14 2020, 7:56 PM

Volker_E added a project: Technical-Debt.Feb 14 2020, 8:04 PM

Change 572317 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Unify SVGO rules to Wikimedia coding conventions and re-crush SVGs

https://gerrit.wikimedia.org/r/572317

When above MN patch is merged, it would be helpful to have @Edtadros look over the changed icons once more.

Change 572317 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Unify SVGO rules to Wikimedia coding conventions and re-crush SVGs

https://gerrit.wikimedia.org/r/572317

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 17 2020, 8:01 PM

Volker_E added a parent task: T178867: [EPIC] Unify and optimize SVG markup across Foundation products.Feb 17 2020, 8:34 PM

Change 572305 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Unify SVGO rules to Wikimedia coding conventions and re-crush SVGs

https://gerrit.wikimedia.org/r/572305

Maintenance_bot removed a project: Patch-For-Review.Feb 18 2020, 2:10 AM

Volker_E assigned this task to Edtadros.Feb 18 2020, 6:46 PM

Volker_E updated the task description. (Show Details)

Given it's assigned to Edward I'm guessing there is a request to QA it, but Edward does not QA task outside the sprint board.

ovasileva moved this task from Needs Analysis to Needs QA on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q3) board.Mar 3 2020, 7:02 PM

Volker_E mentioned this in T178867: [EPIC] Unify and optimize SVG markup across Foundation products.Mar 3 2020, 7:02 PM

Change 575811 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Vector@master] Add SVG minifier script npm run svgmin and unify SVGO rules to Wikimedia coding conventions

https://gerrit.wikimedia.org/r/575811

Change 575812 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Vector@master] Run SVG minifier in Vector skin

https://gerrit.wikimedia.org/r/575812

Test Result

Status: ❌ Fail
OS: Windows 7
Browser: IE11
Device: Browserstack

Test Artifact(s):
Visit https://en.m.wikipedia.org/wiki/Front_end in older Grade A browsers like IE 11 and look out for icons being visually correct, not having rendering issues. Both as logged-in and logged-out user as some icons are login-state specific.

❓ AC1: Logged In

✅
❓	Not icon related, but the letter g gets cut off.
✅
❓	Not icon related, but the letter g gets cut off.

❌ AC2: Not Logged In

❌
✅

Edtadros updated the task description. (Show Details)Mar 5 2020, 5:25 PM

Jdlrobson renamed this task from Unify SVG optimization to Wikimedia coding conventions to Unify SVG optimization to Wikimedia coding conventions in MobileFrontend and Minerva.Mar 5 2020, 6:24 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMar 5 2020, 6:24 PM

Both reported fails by @Edtadros are not connected with the SVG optimization, but separate issues. Will be filed into follow-up tasks.
Resolving this as 'successful' after moving it on kanban board.

Volker_E claimed this task.Mar 5 2020, 8:28 PM

Volker_E moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q3) board.

Volker_E added a subscriber: ovasileva.

In T245296#5946209, @Volker_E wrote:

Both reported fails by @Edtadros are not connected with the SVG optimization, but separate issues. Will be filed into follow-up tasks.
Resolving this as 'successful' after moving it on kanban board.

@Volker_E - sounds good. Resolving. Did you open a new task for the bug? If not, I can do it as well.

Have asked @Edtadros for that…

@Volker_E / @ovasileva here are the bug reports:

[Bug] Decenders get cut off in drop down menus T247145
[Bug] Edit Icons not the same size T247146

Let me know if you need more info or you'd like me to check different browsers/OSes.

TIL what decenders are. 🤓

Thanks @Edtadros - also asked this on the bugs themselves but just to be sure - these are only showing on old desktop browsers, right? Priority would probably increase if it was both desktop & mobile.

@ovasileva I only tested this on IE11. I can test on older browsers if you think it is necessary. I tested it on the browsers mentioned here T247146#5962575 and everything looks fine for both the edit icon size as well as the decender characters.

Unify SVG optimization to Wikimedia coding conventions in MobileFrontend and MinervaClosed, ResolvedPublicActions