Page MenuHomePhabricator
Create Task
Maniphest T245319

Visual Editor Image node has wrong control type
Closed, ResolvedPublicBUG REPORT
Actions

Description

For every empty paragraph created by the visual editor,
it uses a shim image as a placeholder for content.
This image doesn't server any purpose order than being a shim. The fix is to set the role of the image to none for screen readers.

Steps to Reproduce:

  1. Create Visual Editor
  2. Check if Image node has proper control type.

Actual Results:
Image node doesn't have the proper control type

Expected Results:
image node doesn't have the proper control type.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (244656506)mediawiki/extensions/VisualEditormaster+1 -1
Fix: paragraph node image fixVisualEditor/VisualEditormaster+15 -2
Customize query in gerrit

Related Objects

Event Timeline

Akinwale-microsoft created this task.Feb 14 2020, 11:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2020, 11:20 PM
gerritbot added a comment.Feb 14 2020, 11:21 PM

Change 572364 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[VisualEditor/VisualEditor@master] Fix: paragraph node image fix

https://gerrit.wikimedia.org/r/572364

gerritbot added a project: Patch-For-Review.Feb 14 2020, 11:21 PM
matmarex added a project: Editing-team (Q3 2019-2020 Kanban Board).Feb 17 2020, 8:44 PM
matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 17 2020, 8:46 PM
gerritbot added a comment.Feb 25 2020, 9:45 PM

Change 572364 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix: paragraph node image fix

https://gerrit.wikimedia.org/r/572364

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 25 2020, 9:48 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
Maintenance_bot removed a project: Patch-For-Review.Feb 25 2020, 10:11 PM
TheDJ added a project: Accessibility.Feb 25 2020, 11:25 PM
ppelberg closed this task as Resolved.Feb 26 2020, 3:40 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 26 2020, 3:40 AM
ppelberg mentioned this in T245294: Internal and External Link annotation widget.Feb 26 2020, 3:43 AM
gerritbot added a comment.Feb 27 2020, 2:33 AM

Change 575117 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (244656506)

https://gerrit.wikimedia.org/r/575117

gerritbot added a project: Patch-For-Review.Feb 27 2020, 2:33 AM
gerritbot added a comment.Feb 27 2020, 2:38 PM

Change 575117 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (244656506)

https://gerrit.wikimedia.org/r/575117

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.22; 2020-03-03).Feb 27 2020, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 27 2020, 3:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits