Page MenuHomePhabricator

No interaction with newly opened discussion thread
Closed, DeclinedPublic

Description

Author: florian

Description:
I'm using the actual version of LiquidThreads (Revision 62532) on Mediawiki 1.15. This bug strikes me as similar to one DaSch has filed before but his bug report was closed as fixed. Sorry to say it isn't ;).

After starting a new thread (directly after a fresh LiquidThreads installation) on an previously empty discussion page any action regarding this new thread (edit, answer, delete) brings up the following two errors:

1.: in /*mywiki*/\extensions\LiquidThreads\classes\LqtHistoricalThread.php on line 27 PHP Fatal error: Call to a member function id() on a non-object

2.: in /*mywiki*/\extensions\LiquidThreads\classes\LqtHistoricalThread.php on line 46

This problem can be solved by applying the solution Janek provided on your Extension talk page:

  • Comment out lines 215 and 216 in LqtBaseView.php
  • Replace $t->replies with $this->replies in classes/LqtHistoricalThread.php
  • Insert

    if (!$tmt) { return; }

    in the same file after line 42
  • Insert

    if (!$thread) { return; }

    in classes/LqtThread.php after line 106

Of course I'd very much prefer to stay with the original code, but as I'm not into php there's no other choice right now.

Anyway, thanks a lot for LiquidThreads - my users love it!
Regards, Florian


Version: unspecified
Severity: major
OS: Linux
Platform: Other

Details

Reference
bz22532

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:59 PM
bzimport set Reference to bz22532.

Does this still happen? Does it work on MediaWiki 1.16?

Stale bug, unable to reproduce. Likely an incompatibility between LiquidThreads' 1.16 branch and MediaWiki 1.15.