Hard deprecate deprecated api token hooks
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Feb 15 2020, 1:48 AM

Description

The functions use $wgUser, and only after the hooks are removed can the api functionality be removed
Already soft deprecated

Details

	Subject	Repo	Branch	Lines +/-
	Hard-deprecate api hooks for getting tokens	mediawiki/core	master	+11 -5
	Hooks: Remove handler for `ApiTokensGetTokenTypes`	mediawiki/extensions/CentralAuth	master	+0 -40

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T245329 Hard deprecate deprecated api token hooks

Event Timeline

DannyS712 created this task.Feb 15 2020, 1:48 AM

Change 572373 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard-deprecate api hooks and functions for getting tokens

https://gerrit.wikimedia.org/r/572373

gerritbot added a project: Patch-For-Review.Feb 15 2020, 1:53 AM

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Feb 15 2020, 2:08 AM

Amorymeltzer subscribed.Feb 18 2020, 7:12 PM

Change 572976 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralAuth@master] Hooks: Remove handler for ApiTokensGetTokenTypes

https://gerrit.wikimedia.org/r/572976

Change 572976 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Hooks: Remove handler for ApiTokensGetTokenTypes

https://gerrit.wikimedia.org/r/572976

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 18 2020, 10:01 PM

DannyS712 mentioned this in T243708: Mediawiki core needs uses of global $wgUser removed.Feb 22 2020, 1:18 AM

Change 572373 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate api hooks for getting tokens

https://gerrit.wikimedia.org/r/572373

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2020, 5:11 PM

DannyS712 mentioned this in T248022: Remove deprecated api token hooks.Mar 18 2020, 8:21 PM

DannyS712 mentioned this in T241557: Replace $wgUser in core Api modules.Mar 18 2020, 10:21 PM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.25; 2020-03-24); removed MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Mar 19 2020, 8:47 PM

DannyS712 renamed this task from Hard deprecate deprecated api token hooks and functions to Hard deprecate deprecated api token hooks.Mar 23 2020, 5:10 AM

DannyS712 closed this task as Resolved.

DannyS712 updated the task description. (Show Details)

DannyS712 edited projects, added MediaWiki-Core-Hooks; removed MediaWiki-General.Apr 11 2020, 11:06 AM

DannyS712 moved this task from Untriaged to Deprecate/remove on the MediaWiki-Core-Hooks board.Apr 11 2020, 11:10 AM

DannyS712 moved this task from In progress to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:37 AM