Page MenuHomePhabricator

Remove remaining ApiTestCase::doLogin calls
Closed, ResolvedPublic

Description

See T244039: Api tests: Hard deprecate ApiTestCase::doLogin, remove calls in favor of passing a user where needed for deprecation

This method will be removed entirely in 1.36

Code search for (non-deployed) extensions: https://codesearch.wmflabs.org/search/?q=-%3EdoLogin%5C(&i=nope&files=&repos=

  • BlueSpiceChecklist
  • BlueSpiceBookshelf
  • BlueSpiceDashboards
  • BlueSpiceFoundation
  • BlueSpiceReminder
  • BlueSpiceAvatars
  • BlueSpiceInsertFile
  • BlueSpiceUserManager

Note that the calls in the "Push" and "LinkedWiki" extensions refer to ApiPushBase::doLogin

Event Timeline

Change 572383 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceChecklist@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572383

Change 572384 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceBookshelf@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572384

Change 572386 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceDashboards@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572386

Change 572389 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceFoundation@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572389

Change 572390 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceReminder@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572390

Change 572392 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceInsertFile@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572392

This task does not seem to be about the MediaWiki Core codebase, hence removing that tag.

This task does not seem to be about the MediaWiki Core codebase, hence removing that tag.

This task is for the removal of the function from core; the patches submitted removed some of the callers

@DannyS712: That sounds like two separate tasks and the extension tasks should be subtasks of the MediaWiki core task.

@DannyS712: That sounds like two separate tasks and the extension tasks should be subtasks of the MediaWiki core task.

The removal from extensions isn't needed, since its only for extensions not deployed on WMF wikis, so I didn't make a separate task, but rather linked here in those. Is that not okay?

I don't think there are any "rules" about this. To me personally it feels messy, and from reading the task description here it wasn't clear at all to me that this is about removing stuff from MediaWiki Core, as there is only a checklist for extensions. :)

I don't think there are any "rules" about this. To me personally it feels messy, and from reading the task description here it wasn't clear at all to me that this is about removing stuff from MediaWiki Core, as there is only a checklist for extensions. :)

I'll be clearer in future tasks, but I'd like to leave this as is

DannyS712 renamed this task from Remove ApiTestCase::doLogin to Remove remaining ApiTestCase::doLogin calls.Feb 16 2020, 7:48 AM
DannyS712 removed a project: MediaWiki-General.
DannyS712 updated the task description. (Show Details)

Change 572392 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceInsertFile@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572392

Change 572389 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572389

Change 572390 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceReminder@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572390

Change 572386 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceDashboards@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572386

Change 572384 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceBookshelf@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572384

Change 572383 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceChecklist@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572383

Change 572508 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceAvatars@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572508

Change 572509 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceUserManager@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572509

DannyS712 triaged this task as Medium priority.Feb 19 2020, 1:22 AM

Change 572508 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceAvatars@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572508

Change 572509 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceUserManager@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572509

DannyS712 updated the task description. (Show Details)