use api.Request MutableMapping methods instead of direct access to Request._params
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Feb 15 2020, 10:50 AM

Description

api.Request is a MutableMapping with set/get/del functionality to modify Request._params dict. This should be used to assing or retrieve or delete Parameters instead of direct usage of Request._params to avoid errors like that found in T245318

Details

	Subject	Repo	Branch	Lines +/-
	[IMPR] use getter/setter with api.Request	pywikibot/core	master	+11 -11

Customize query in gerrit

Related Objects

Mentioned In: rPWBCa69ba02259f4: [IMPR] use getter/setter with api.Request
Mentioned Here: T245318: APIErrors for maxlag parameter higher than 9 starting February 12

Event Timeline

Xqt created this task.Feb 15 2020, 10:50 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptFeb 15 2020, 10:50 AM

Xqt triaged this task as Low priority.Feb 15 2020, 10:50 AM

Change 572561 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] use getter/setter with api.Request

https://gerrit.wikimedia.org/r/572561

gerritbot added a project: Patch-For-Review.Feb 17 2020, 7:46 AM

Xqt claimed this task.Feb 17 2020, 7:46 AM

Change 572561 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] use getter/setter with api.Request

https://gerrit.wikimedia.org/r/572561

Xqt mentioned this in rPWBCa69ba02259f4: [IMPR] use getter/setter with api.Request.Mar 28 2020, 10:25 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 28 2020, 11:10 PM

Xqt closed this task as Resolved.Mar 29 2020, 7:12 AM

use api.Request MutableMapping methods instead of direct access to Request._paramsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

use api.Request MutableMapping methods instead of direct access to Request._params
Closed, ResolvedPublic
Actions