Maniphest T245355

Remove ApiTestCase::doLogin
Closed, ResolvedPublic
Actions

Description

Following hard deprecation and removal of all known uses, ApiTestCase::doLogin should be removed entirely

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove hard deprecated ApiTestCase::doLogin	mediawiki/core	master	+3 -26

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T11968 Reduce use of global and public variables
		Open		None	T159283 Deprecate non-configuration globals
		Resolved		MGChecker	T159299 Deprecate and remove $wgUser
		Resolved		DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
		Resolved		MGChecker	T243708 Mediawiki core needs uses of global $wgUser removed
		Resolved		DannyS712	T245331 Remove core fallbacks to global $wgUser [1.36]
		Resolved		DannyS712	T245355 Remove ApiTestCase::doLogin
		Resolved		DannyS712	T245332 Remove remaining ApiTestCase::doLogin calls

Event Timeline

Cannot be actioned until 1.36

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Feb 16 2020, 7:49 AM

DannyS712 triaged this task as Medium priority.Feb 19 2020, 1:22 AM

DannyS712 closed subtask T245332: Remove remaining ApiTestCase::doLogin calls as Resolved.Feb 20 2020, 9:26 AM

DannyS712 mentioned this in T243708: Mediawiki core needs uses of global $wgUser removed.Feb 22 2020, 1:18 AM

DannyS712 moved this task from Next to Later on the User-DannyS712 board.Apr 13 2020, 9:12 PM

DannyS712 changed the task status from Stalled to Open.Jul 14 2020, 9:52 AM

Change 616028 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove hard deprecated ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/616028

gerritbot added a project: Patch-For-Review.Jul 24 2020, 9:17 AM

DannyS712 moved this task from Later to Awaiting review and deployment on the User-DannyS712 board.Jul 24 2020, 9:19 AM

DannyS712 added a project: Platform Team Workboards (External Code Reviews).

Change 616028 merged by jenkins-bot:
[mediawiki/core@master] Remove hard deprecated ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/616028

DannyS712 closed this task as Resolved.Jul 27 2020, 7:35 PM

DannyS712 removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 27 2020, 8:00 PM