Page MenuHomePhabricator

Diffs should include semantic information for screen readers
Closed, ResolvedPublic

Description

In the same way that we add a CSS class to highlight differing content in diff and conflict views, we should also be adding accessibility markup so that screen-reading technology can say something like, "added text: 'blah'".

For comparison, a screen reader might say "link: 'link label'" when reading an inline link.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

We kinda do now with the del/ins markup which is now read by JAWS and NVDA ... and I've heard VoiceOver on iOS at least also indicates it. I mentioned this in T280749.

I've heard VoiceOver on iOS at least also indicates it

I can confirm this. Just tested and ins and del now work on iOS, but not yet on macOS (although I haven't updated to the new macOS major version yet, so maybe it works in the new major version).

[Edit] Tested new version of macOS and it does not yet support ins and del.

I can confirm this. Just tested and ins and del now work on iOS, but not yet on macOS (although I haven't updated to the new macOS major version yet, so maybe it works in the new major version).

Tested on Safari 17 and macOS Sonoma 14, and finally ins and del are supported ! If you use the inline diff mode now, it's a lot easier to follow in my opinion.

WMDE-Fisch closed this task as Resolved.EditedOct 31 2023, 11:20 AM
WMDE-Fisch subscribed.

Also confirming that del/ins are read by JAWS and NVDA. Tested both with Firefox and Chrome. I'll close this task as resolved.

Just in case anyone else needs ins/del. I later discovered that this only works in VoiceOver due to the usage of the title= attribute. Without that attribute it ignores ins and del. I have no idea why. It doesn't make much sense. It could be an implementation error on the VoiceOver side.