Page MenuHomePhabricator

Update vue cli
Closed, DeclinedPublic

Description

4 is out for a while (and stable enough now) while our pinned 3.8.4 is starting to throw warnings.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Wait, why do we install vue cli in the dockerfile? And what does that even do? Because I don’t use the dockerfile, and apparently I’m still able to run tests and produce builds that pass the distnodiff check in CI.

I'm sorry for having put this in "Task overflow" (apparently) - that was not my intention.
Meant "tech things".

Wait, why do we install vue cli in the dockerfile

It allows the global (-g) installation of packages resulting in a binary in path.
This allows for usage as documented and maybe known to/expected by vue devs.

That said: I'm not sure any one of us actually uses it in their workflow.

Okay, as far as I can tell we don’t need it at all – we use npm run build instead of vue build, npm run serve instead of vue serve, and so on. If I understand correctly, it can be useful to have vue cli globally installed in general, but it doesn’t really belong in this Dockerfile, I think.

Change 572692 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: remove vue cli from Dockerfile

https://gerrit.wikimedia.org/r/572692

Change 572692 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: remove vue cli from Dockerfile

https://gerrit.wikimedia.org/r/572692