Page MenuHomePhabricator

lyricwiki family is very outdated
Closed, ResolvedPublic

Description

Event Timeline

Xqt triaged this task as Low priority.Feb 17 2020, 2:23 PM

Change 572748 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[pywikibot/core@master] Update lyricwiki_family.py

https://gerrit.wikimedia.org/r/572748

Change 572748 merged by jenkins-bot:
[pywikibot/core@master] Update lyricwiki_family.py

https://gerrit.wikimedia.org/r/572748

In T245439#5891861, @Zoranzoki21 wrote:

So, this is resolved or what? @Xqt

The closed wiki isn’t solved yet. Keep it open therefore.

It seems to me it is not closed as admins still can edit pages there. Closed is closed also for local admins I believe and only stewards (or their equivalent) can edit pages then.

Kizule subscribed.

It seems to me it is not closed as admins still can edit pages there. Closed is closed also for local admins I believe and only stewards (or their equivalent) can edit pages then.

No closing is announced for September 2020.

Should we still keep this family file?

It seems to me it is not closed as admins still can edit pages there. Closed is closed also for local admins I believe and only stewards (or their equivalent) can edit pages then.

No closing is announced for September 2020.

Should we still keep this family file?

I think that we shouldn't, as closing is announced, so editing won't be possible.

Umm, this family is also used and in tests?

zoranzoki21@LAPTOP-5EQT28MA:~/development/pywikibot-core$ git grep lyricwiki
docs/api_ref/pywikibot.families.rst:pywikibot.families.lyricwiki\_family module
docs/api_ref/pywikibot.families.rst:.. automodule:: pywikibot.families.lyricwiki_family
pywikibot/families/lyricwiki_family.py:# usernames['lyricwiki']['en'] = 'user'
pywikibot/families/lyricwiki_family.py:    name = 'lyricwiki'
tests/family_tests.py:                if family in ('wowwiki', 'lyricwiki'):
tests/logentries_tests.py:    still read the older format. It currently uses lyricwiki which as of
tests/logentries_tests.py:            'family': 'lyricwiki',
tests/site_tests.py:    family = 'lyricwiki'
tests/site_tests.py:        self.assertRaises(KeyError, site.family.hostname, 'lyricwiki')
tests/site_tests.py:                          'lyricwiki', 'lyricwiki')
tests/site_tests.py:                          'de', 'lyricwiki')

Change 630367 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Remove lyricwiki_family.py from framework

https://gerrit.wikimedia.org/r/630367

Change 630380 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] replace lyrics site tests by wowwiki

https://gerrit.wikimedia.org/r/630380

Change 630380 merged by jenkins-bot:
[pywikibot/core@master] [tests] replace lyrics site tests by wowwiki

https://gerrit.wikimedia.org/r/630380

Change 630367 merged by jenkins-bot:
[pywikibot/core@master] [tests] Remove lyricwiki_family.py from framework

https://gerrit.wikimedia.org/r/630367

Kizule assigned this task to Xqt.

As I can't find usages of this family anymore, and tests because of this shouldn't fail anymore, I think that this is resolved.

Closing task...