Page MenuHomePhabricator

Add option to exclude errors from templates
Open, Stalled, Needs TriagePublic


As a user
When I go to (for example) and want to clean up lint errors
I should be able to hide errors that result from an included template

Event Timeline

Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 18 2020, 1:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 572759 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Linter@master] Special:LintErrors - allow excluding lint errors from templates

Completely forgot to upload the patch, woops

DannyS712 changed the task status from Open to Stalled.Jul 3 2020, 4:04 AM
DannyS712 added a subscriber: Legoktm.

@Legoktm pointed out that there isn't an index on linter_params, and so the query would be slow - stalling pending discussion of if an index can be added

No, linter_params isn't ever going to get an index, as it's just a JSON blob. We would have to introduce a new linter_template field that just contains the template's name or is null.

One option could be just hiding it client side with JS, but that could cause weird pagination problems (it would be possible to get results and then have all of them hidden by JS).

How important is adding this filter?

Not very - I hide it client side with javascript currently