Page MenuHomePhabricator

Signature not expanded in the TwoColConflict preview interface
Closed, ResolvedPublic3 Estimated Story Points

Description

When the conflict includes something like ~~~~ (the users signature on talk pages), this is shown as is in the diff in the TwoColConflict interface. The pre-save transformations are not run before creating the diff.

https://www.mediawiki.org/wiki/Pre-save_transforms

Expected: The diff shows the users signature expanded.

Note: This sounds like it is the same issue we fixed before, but that was for the preview, which is JavaScript code. This bug here is in the backend.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
thiemowmde set the point value for this task to 3.Feb 18 2020, 1:35 PM

Change 572891 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] [WIP] Run pre-save transformations before creating the diff

https://gerrit.wikimedia.org/r/572891

awight renamed this task from Signature not expanded in the TwoColConflict interface to Signature not expanded in the TwoColConflict preview interface.Feb 19 2020, 11:15 AM

Change 573983 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Remove more unused code from SplitTwoColConflictHelper

https://gerrit.wikimedia.org/r/573983

Change 573983 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Remove more unused code from SplitTwoColConflictHelper

https://gerrit.wikimedia.org/r/573983

Change 572891 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Run pre-save transformations before creating the diff

https://gerrit.wikimedia.org/r/572891

thiemowmde moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-02-19 board.