Page MenuHomePhabricator

Radio elements in TwoColConflict don't show a keyboard focus indicator
Closed, ResolvedPublic2 Estimated Story Points

Description

The radio buttons (the blue and yellow circles in the middle of the TwoColConflict interface) are colored via CSS. It appears like this extra coloring destroyed the focus styling for these elements (a thin white circle is shown on top of the blue radio button). Using the tab key to focus elements on the page gets confusing because the radio buttons don't show a visual indicator for the focus. The original OOUI element is able to do this, see https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 572868 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Restore broken focus indicator on radio elements

https://gerrit.wikimedia.org/r/572868

thiemowmde set the point value for this task to 2.Feb 18 2020, 1:35 PM

Change 572868 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Restore broken focus indicator on radio elements

https://gerrit.wikimedia.org/r/572868

thiemowmde claimed this task.
thiemowmde moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-02-19 board.