Page MenuHomePhabricator

InvalidArgumentException during Wikibase initialization on Beta Wikidata
Closed, ResolvedPublic

Description

https://wikidata.beta.wmflabs.org/

[XkweU6wQBHcAACZ9NR8AAAAY] / InvalidArgumentException from line 77 of /srv/mediawiki/php-master/extensions/Wikibase/data-access/src/EntitySourceDefinitionsConfigParser.php: Entity namespaces of entity source "wikidata" should be either a string or an integer

Backtrace:

#0 /srv/mediawiki/php-master/extensions/Wikibase/data-access/src/EntitySourceDefinitionsConfigParser.php(23): Wikibase\DataAccess\EntitySourceDefinitionsConfigParser->assertConfigArrayWellFormed(array)
#1 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php(466): Wikibase\DataAccess\EntitySourceDefinitionsConfigParser->newDefinitionsFromConfigArray(array, Wikibase\Lib\EntityTypeDefinitions)
#2 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php(420): Wikibase\Repo\WikibaseRepo::getEntitySourceDefinitionsFromSettings(Wikibase\SettingsArray, Wikibase\Lib\EntityTypeDefinitions)
#3 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php(480): Wikibase\Repo\WikibaseRepo::newInstance()
#4 /srv/mediawiki/php-master/extensions/Wikibase/repo/RepoHooks.php(109): Wikibase\Repo\WikibaseRepo::getDefaultInstance()
#5 /srv/mediawiki/php-master/includes/Hooks.php(174): Wikibase\RepoHooks::onSetupAfterCache()
#6 /srv/mediawiki/php-master/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#7 /srv/mediawiki/php-master/includes/Setup.php(766): Hooks::run(string)
#8 /srv/mediawiki/php-master/includes/WebStart.php(89): require_once(string)
#9 /srv/mediawiki/php-master/index.php(44): require(string)
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}

Event Timeline

Just to add to the documentation of this incident: did this only break beta in some subtle way? I saw there was a 5 hour-ish gap between the patch being +2 and us reverting.

What was the impact of this breakage? All of beta wikidata down? Or just entity pages?

What was the impact of this breakage? All of beta wikidata down? Or just entity pages?

All beta wikidata down. in terms of code every call to constructor of WikibaseRepo/WikibaseClient should have resulted in the exception, as far as I understand. So well done to WMDE for only spotting this after 5-6 hours.