After closing the reply box on fr.wiki, there is a blue border showing up on the talk page
Tried on this page: https://fr.wikipedia.org/wiki/Discussion_Wikip%C3%A9dia:Accueil_principal?dtenable=1
Screenshots:
Ryasmeen | |
Feb 18 2020, 11:49 PM |
F31662764: Screen Shot 2020-03-04 at 2.07.30 PM.png | |
Mar 4 2020, 10:07 PM |
F31621817: Screen Shot 2020-02-18 at 3.39.17 PM.png | |
Feb 18 2020, 11:49 PM |
F31621814: Screen Shot 2020-02-18 at 3.45.20 PM.png | |
Feb 18 2020, 11:49 PM |
After closing the reply box on fr.wiki, there is a blue border showing up on the talk page
Tried on this page: https://fr.wikipedia.org/wiki/Discussion_Wikip%C3%A9dia:Accueil_principal?dtenable=1
Screenshots:
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Clean up the interface after discarding a reply | mediawiki/extensions/DiscussionTools | master | +76 -7 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T233443 [Epic] Reply Tool | |||
Resolved | • ppelberg | T235923 Replies v1.0: release replying to specific comments | |||
Resolved | • ppelberg | T236951 Deploy Replying v1.0 to target wikis | |||
Resolved | Ryasmeen | T244432 Evaluate reliability of #DiscussionTools on target wikis | |||
Resolved | matmarex | T244870 Deploy v1.0 via query string parameter to target wikis | |||
Resolved | matmarex | T243621 Create query string parameter to enable/disable DiscussionTools on target wikis | |||
Invalid | None | T245571 Reply link does not appear on the first time loading DiscussionTools (on hu and ar wiki) | |||
Resolved | matmarex | T245574 After closing the reply box on fr.wiki, there is a blue border showing up on the talk page |
The blue box appears because of custom styling for discussions on fr.wp. But the underlying issue is in our code, we don't properly clean up cancelled replies. You can also see similar issues when replying to a comment in a bullet list on any wiki (after closing the reply box, some extraneous bullet points will remain visible).
@matmarex can you confirm the following are true?
Gotcha. I'm moving this to "Required before release" (perhaps this was your intention in marking the priority as "High"?).
While this behavior isn't "breaking" by any means, I'd like for people to have confidence the core parts of the workflow (e.g. writing a comment, cancelling a comment, publishing a comment, etc. ) work in the way they expect them to.
Change 574609 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Clean up the interface after discarding a reply
Once this is out of code review, @Ryasmeen can take a look at this in production on Thursday
Change 574609 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Clean up the interface after discarding a reply