Page MenuHomePhabricator

Toggle buttons in table properties do have names missing label
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Navigate till Visual editor
  2. Navigate till "Tables" and hit enter , click on the "Properties" control .
  3. Verify using Accessibility Insights tool

Actual Results:
Toggle buttons don't have an aria-label

Expected Results:
Toggle buttons must have aria-label

Event Timeline

Change 573042 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[VisualEditor/VisualEditor@master] Fix: Added aria-label to caption toggle element

https://gerrit.wikimedia.org/r/573042

matmarex added subscribers: Volker_E, matmarex.

I think this is an OOUI bug – we're using FieldLayout there, which should connect the widgets to their labels. For regular HTML form elements, this already works correctly, using <label for=…>. I don't see why we don't do it for custom widgets using aria-labelledby?

Change 574867 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] FieldLayout: Use 'aria-labelledby' for accessibility of non-form elements

https://gerrit.wikimedia.org/r/574867

Change 574867 merged by jenkins-bot:
[oojs/ui@master] FieldLayout: Use 'aria-labelledby' for accessibility of non-form elements

https://gerrit.wikimedia.org/r/574867

Volker_E moved this task from Backlog to OOUI-0.37.0 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.37.0); removed OOUI.

Change 575115 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.37.0

https://gerrit.wikimedia.org/r/575115

Change 575115 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.37.0

https://gerrit.wikimedia.org/r/575115

Change 573042 abandoned by Bartosz Dziewoński:
Fix: Added aria-label to caption toggle element

Reason:
Resolved by https://gerrit.wikimedia.org/r/c/oojs/ui/ /574867

https://gerrit.wikimedia.org/r/573042

matmarex removed a project: Patch-For-Review.

The OOUI patch seems to resolve the problems in the table dialog in my testing, @Akinwale-microsoft I'd appreciate if you could also recheck :) Thanks for reporting this!

JTannerWMF added a subscriber: JTannerWMF.

Assigning to Marcella for close out